[Docs] Replace johns-apparel with IANA-reserved domain #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
This comment has been minimized.
This comment has been minimized.
rennyG
added
the
includes-post-release-steps
Coverage report
Test suite run success1788 tests passing in 813 suites. Report generated by 🧪jest coverage report action from 7243346 |
isaacroldan
reviewed
Jul 29, 2024
|
To tophat you need to manually copy the doc files into shopify-dev (in the CLI docs folder) |
isaacroldan
approved these changes
Jul 30, 2024
|
/shipit |
|
👋🏼 This change has been released, so it's time to run the post-release steps! |
isaacroldan
removed
the
includes-post-release-steps
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Partially addresses https://github.com/Shopify/shopify-dev/issues/46788
WHAT is this pull request doing?
Replace johns-apparel in CLI docs with IANA-reserved domain for technical documentation
How to test your changes?
🎩
Copied files to
shopify-devExample of change in CLI docs there
Post-release steps
Need to publish documentation pages
Measuring impact
How do we know this change was effective? Please choose one:
Checklist