Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm asset support for theme app extensions #4229

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

itsjustriley
Copy link
Contributor

WHY are these changes introduced?

Resolves #3893

WHAT is this pull request doing?

Adds .wasm asset support to theme app extensions. Another PR has already been shipped to enable this upstream

How to test your changes?

  • Create a new app with a theme app extension
  • Add a .wasm file in the assets folder
  • Run the app dev command
  • Notice the theme app extension is pushed as expected

Post-release steps

None

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jul 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.48% (+0.12% 🔼)
7815/10782
🟡 Branches
69.44% (+0.07% 🔼)
3849/5543
🟡 Functions
71.3% (+0.03% 🔼)
2059/2888
🟡 Lines
72.78% (+0.13% 🔼)
7379/10139

Test suite run success

1788 tests passing in 813 suites.

Report generated by 🧪jest coverage report action from 2387329

@itsjustriley itsjustriley force-pushed the wasm-asset-support branch 4 times, most recently from efd8fa2 to 666c108 Compare July 22, 2024 13:22
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @itsjustriley!

@itsjustriley itsjustriley added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 4867926 Jul 22, 2024
@itsjustriley itsjustriley deleted the wasm-asset-support branch July 22, 2024 13:54
@thosakwe
Copy link

Thank you so much for implementing WASM support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for WASM file format in assets in theme app extensions
3 participants