Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli-hydrogen dep #4215

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 16, 2024

Mirror of #4214 for the stable branch

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.46% 7547/10416
🟡 Branches 69.2% 3719/5374
🟡 Functions 71.44% 1996/2794
🟡 Lines 72.78% 7127/9792

Test suite run success

1736 tests passing in 800 suites.

Report generated by 🧪jest coverage report action from cb71a1f

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/context/fqdn.d.ts
@@ -15,12 +15,6 @@ export declare function partnersFqdn(): Promise<string>;
  * @returns Fully-qualified domain of the App Management service we should interact with.
  */
 export declare function appManagementFqdn(): Promise<string>;
-/**
- * It returns the Developer Dashboard domain we should interact with.
- *
- * @returns Fully-qualified domain of the Developer Dashboard we should interact with.
- */
-export declare function developerDashboardFqdn(): Promise<string>;
 /**
  * It returns the BusinessPlatform' API service we should interact with.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants