Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Match webhooks by comparing relative and absolute paths #4150

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

The backend always returns an absolute path, but the CLI might only have relative ones.

WHAT is this pull request doing?

Use endsWith to compare relative and absolute URIs

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

@isaacroldan isaacroldan changed the base branch from main to stable/3.63 July 3, 2024 08:49
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.64% 7480/10298
🟡 Branches 69.23% 3677/5311
🟡 Functions 71.59% 1976/2760
🟡 Lines 72.98% 7066/9682

Test suite run success

1720 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from 3f98e53

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.63.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.63.1";
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants