Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.63] Avoid loop when users pass the --theme-editor-sync flag in the shopify theme dev command #4143

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Jul 1, 2024

Back-port: #4142

@karreiro karreiro requested a review from jamesmengo July 1, 2024 12:02
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.63.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.63.1";
\ No newline at end of file

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.63% 7479/10297
🟡 Branches 69.24% 3676/5309
🟡 Functions 71.59% 1976/2760
🟡 Lines 72.98% 7065/9681

Test suite run success

1720 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from 3c02813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants