Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy prompt with existing Subscription UI #4061

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

If you create a Subscription UI and deploy, the next time it keeps showing it as new (but it's already released)

image

WHAT is this pull request doing?

Add a missing identifier for that kind of extension, so it matches the remote one.

How to test your changes?

  • p shopify app generate extension --template subscription_ui
  • p shopify app deploy
  • p shopify app deploy

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.03% (-0.08% 🔻)
7369/10231
🟡 Branches
68.9% (-0.11% 🔻)
3612/5242
🟡 Functions
71.54% (-0.07% 🔻)
1953/2730
🟡 Lines
73.29% (-0.08% 🔻)
6950/9483
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / system.ts
5.26% (-21.05% 🔻)
0% (-20.69% 🔻)
25% (-25% 🔻)
5.56% (-22.22% 🔻)

Test suite run success

1700 tests passing in 792 suites.

Report generated by 🧪jest coverage report action from ec0854a

@gonzaloriestra gonzaloriestra marked this pull request as ready for review June 17, 2024 11:43
@gonzaloriestra gonzaloriestra merged commit 6a7c571 into main Jun 17, 2024
@gonzaloriestra gonzaloriestra deleted the fix-product-subscription-id branch June 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants