Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duplicate print action message #4002

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Update duplicate print action message #4002

merged 1 commit into from
Jun 7, 2024

Conversation

MitchLillie
Copy link
Contributor

WHY are these changes introduced?

Fixes https://github.com/Shopify/app-ui/issues/1192

WHAT is this pull request doing?

Updating the error message shown when dev'ing or deploying multiple print extensions with the same target. Also updated to use the handle rather than app name as it is unique.

Before:
Screenshot 2024-06-06 at 12 57 25 PM

After:
Screenshot 2024-06-06 at 1 00 05 PM

How to test your changes?

  1. Have an app with multiple print extensions for the same target (wiki)
  2. From this repo, run cli-spin pnpm shopify app dev --path ../to-your-app
  3. Assert that you see the expected message.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.97% (+0.01% 🔼)
7268/10099
🟡 Branches
69.15% (+0.02% 🔼)
3564/5154
🟡 Functions 71.54% 1941/2713
🟡 Lines
73.26% (+0.01% 🔼)
6844/9342

Test suite run success

1688 tests passing in 785 suites.

Report generated by 🧪jest coverage report action from 379c0e9

Copy link
Contributor

@elanalynn elanalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

Screenshot 2024-06-06 at 2 22 49 PM

@MitchLillie MitchLillie added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit ac34fd9 Jun 7, 2024
@MitchLillie MitchLillie deleted the ml/print-warning branch June 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants