Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node engines #3992

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Update Node engines #3992

merged 1 commit into from
Jun 6, 2024

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Jun 6, 2024

WHY are these changes introduced?

The Remix template has been updated to support Node 22, using this new feature only included in:

  • Node 18.20 or higher
  • Node 20.10 or higher
  • Node 21.0 or higher
  • Node 22.0 or higher

WHAT is this pull request doing?

  • Updates the engines for all the packages

How to test your changes?

Try pnpm install with different Node versions

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.87% 7273/10120
🟡 Branches 68.93% 3561/5166
🟡 Functions 71.56% 1945/2718
🟡 Lines 73.16% 6847/9359

Test suite run success

1688 tests passing in 785 suites.

Report generated by 🧪jest coverage report action from d2c6cf2

Copy link
Contributor

@amcaplan amcaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible it might make more sense to upgrade only the packages which are relevant to app creation/running? I.e., create-app and app

This way theme users can continue unhindered.

Or does this not matter now with global CLI?

@isaacroldan
Copy link
Contributor

@amcaplan it doesn't matter, for end users the relevant engine is the one in @shopify/cli
For us we do need to set an engine in all packages

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 49a04d7 Jun 6, 2024
@gonzaloriestra gonzaloriestra deleted the update-node-engines branch June 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants