-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node engines #3992
Update Node engines #3992
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1688 tests passing in 785 suites. Report generated by 🧪jest coverage report action from d2c6cf2 |
85d4f42
to
d2c6cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible it might make more sense to upgrade only the packages which are relevant to app creation/running? I.e., create-app
and app
This way theme
users can continue unhindered.
Or does this not matter now with global CLI?
@amcaplan it doesn't matter, for end users the relevant engine is the one in |
WHY are these changes introduced?
The Remix template has been updated to support Node 22, using this new feature only included in:
WHAT is this pull request doing?
How to test your changes?
Try
pnpm install
with different Node versionsMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.