-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove punycode warning in Node 22 #3976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1684 tests passing in 781 suites. Report generated by 🧪jest coverage report action from 4448359 |
gonzaloriestra
changed the title
Remove warning in Node 22
Remove punycode warning in Node 22
Jun 4, 2024
isaacroldan
approved these changes
Jun 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 6, 2024
in which shopify-cli version we could expect this to be published? p.s. thank you so much @gonzaloriestra |
@ivanafanasyeu It's been included in v3.61.1 |
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3967
WHY are these changes introduced?
The CLI shows a deprecation warning with Node 22 on every run:
That deprecated library was used by whatwg-url < 9.0, which is used by node-fetch 2.7.0, which is used by many dependencies of the CLI.
WHAT is this pull request doing?
node-fetch
> 3, so I'm pinningwhatwg-url
to the latest version, that doesn't require punycode.How to test your changes?
p shopify version
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.