Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove punycode warning in Node 22 #3976

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Remove punycode warning in Node 22 #3976

merged 2 commits into from
Jun 6, 2024

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Jun 4, 2024

Fixes #3967

WHY are these changes introduced?

The CLI shows a deprecation warning with Node 22 on every run:

Monosnap -zsh 2024-06-04 12-30-54


That deprecated library was used by whatwg-url < 9.0, which is used by node-fetch 2.7.0, which is used by many dependencies of the CLI.

WHAT is this pull request doing?

  • It's not easy to upgrade all the dependencies to use node-fetch > 3, so I'm pinning whatwg-url to the latest version, that doesn't require punycode.
  • Sets Node 22 as the default version in development

How to test your changes?

p shopify version

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.94% (-0.01% 🔻)
7236/10059
🟡 Branches
69.06% (-0.02% 🔻)
3565/5162
🟡 Functions 71.57% 1936/2705
🟡 Lines
73.2% (-0.01% 🔻)
6813/9307
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88.89% (-5.56% 🔻)
100%
98.31% (-1.69% 🔻)

Test suite run success

1684 tests passing in 781 suites.

Report generated by 🧪jest coverage report action from 4448359

@gonzaloriestra gonzaloriestra marked this pull request as ready for review June 4, 2024 10:32
@gonzaloriestra gonzaloriestra changed the title Remove warning in Node 22 Remove punycode warning in Node 22 Jun 4, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jun 6, 2024
@gonzaloriestra gonzaloriestra removed this pull request from the merge queue due to a manual request Jun 6, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jun 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit c69f7fa Jun 6, 2024
@gonzaloriestra gonzaloriestra deleted the pin-whatwg-url branch June 6, 2024 16:16
@ivanafanasyeu
Copy link

ivanafanasyeu commented Jun 6, 2024

in which shopify-cli version we could expect this to be published?

p.s. thank you so much @gonzaloriestra

@gonzaloriestra
Copy link
Contributor Author

@ivanafanasyeu It's been included in v3.61.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: deprecated punycode error, while running shopify commands
3 participants