Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Only build flow template extensions during deploy #3885

Merged
merged 2 commits into from
May 10, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

  • Flow templates introduced a new build step to include localization files in the bundled zip file.
  • This build step is only meant for deploy and it currently fails during dev

WHAT is this pull request doing?

  • Don't build flow template extensions if env is development
  • Even if we build, check that we are not building in the wrong path.

How to test your changes?

  • Create a flow template extension
  • Try to dev, it should work (crashes on main)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.9% 6961/9682
🟡 Branches 68.76% 3427/4984
🟡 Functions 71.29% 1860/2609
🟡 Lines 73.21% 6561/8962

Test suite run success

1637 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from cfe97ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants