Fix the shopify theme dev/shopify theme console proxy to handle cookies as expected
#3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1633 tests passing in 763 suites. Report generated by 🧪jest coverage report action from 6010209 |
…ookies as expected, and ensure they no longer render the live theme instead of the development theme
karreiro
force-pushed
the
fix-cookies-theme-dev
branch
from
a01cb51
to
6010209
Compare
isaacroldan
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixed the
shopify theme dev/shopify theme consoleproxy to handle cookies as expected, and ensured they no longer render the live theme instead of the development theme.WHAT is this pull request doing?
With the session cookie being renamed, the CLI needed to follow that change [1] [2]. However, the new regular expression captures the
;, which was creating a scenario like this:This is not an issue when the session cookie is the last one in the cookie string, but when it's in the middle of the string, it depends on the client's fallback behavior, which creates an intermittent behavior.
The browser sometimes is able to infer the cookie correctly, but in scenarios like when the
--passwordflag is passed, where we have the Theme Access app in the middle, the proxy was consistently failing on passing the cookie. Now, we're always appending the;even when the trailing semicolon is supported.This PR also removes the
storefront_session.nil?from theauth_middleware.rb, which is related to the behavior of rendering the live theme in the context ofshopify theme console. Removing this is important because stores that are not password protected don't have that cookie.How to test your changes?
shopify theme devTo test this change in the
shopify theme devcommand, you may run it with the--passwordflag, or reduce the expiration date on the proxy (to force the cookie update) as the video shows:shopify theme consoleTo test this change in the
shopify theme consolecommand, you may run the command on a store that is not password-protected:Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.