Merge pull request #4461 from Shopify/jm/cleanlog

Clean up unused flags from app logs file
Shopify · Sep 19, 2024 · 9995d54 · 9995d54
2 parents d33e946 + d887a97
commit 9995d54
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 45 deletions.
diff --git a/packages/app/src/cli/commands/app/logs.ts b/packages/app/src/cli/commands/app/logs.ts
@@ -34,10 +34,6 @@ export default class Logs extends Command {
       parse: async (input) => normalizeStoreFqdn(input),
     }),
     reset: Dev.flags.reset,
-    'no-tunnel': Dev.flags['no-tunnel'],
-    'graphiql-port': Dev.flags['graphiql-port'],
-    'graphiql-key': Dev.flags['graphiql-key'],
-    stable: Dev.flags.legacy,
     source: Flags.string({
       description: 'Filters output to the specified log source.',
       env: 'SHOPIFY_FLAG_SOURCE',
@@ -60,14 +56,12 @@ export default class Logs extends Command {
 
     const apiKey = flags['client-id'] || flags['api-key']
 
-    const sources = flags.source
-
     await checkFolderIsValidApp(flags.path)
     const logOptions = {
       apiKey,
       directory: flags.path,
       storeFqdns: flags.store,
-      sources,
+      sources: flags.source,
       status: flags.status,
       configName: flags.config,
       reset: flags.reset,

diff --git a/packages/cli/oclif.manifest.json b/packages/cli/oclif.manifest.json
@@ -1584,24 +1584,6 @@
           "name": "config",
           "type": "option"
         },
-        "graphiql-key": {
-          "description": "Key used to authenticate GraphiQL requests. Should be specified if exposing GraphiQL on a publicly accessible URL. By default, no key is required.",
-          "env": "SHOPIFY_FLAG_GRAPHIQL_KEY",
-          "hasDynamicHelp": false,
-          "hidden": true,
-          "multiple": false,
-          "name": "graphiql-key",
-          "type": "option"
-        },
-        "graphiql-port": {
-          "description": "Local port of the GraphiQL development server.",
-          "env": "SHOPIFY_FLAG_GRAPHIQL_PORT",
-          "hasDynamicHelp": false,
-          "hidden": true,
-          "multiple": false,
-          "name": "graphiql-port",
-          "type": "option"
-        },
         "json": {
           "allowNo": false,
           "char": "j",
@@ -1618,18 +1600,6 @@
           "name": "no-color",
           "type": "boolean"
         },
-        "no-tunnel": {
-          "allowNo": false,
-          "description": "Automatic creation of a tunnel is disabled. Service entry point will listen to localhost instead",
-          "env": "SHOPIFY_FLAG_NO_TUNNEL",
-          "exclusive": [
-            "tunnel-url",
-            "tunnel"
-          ],
-          "hidden": true,
-          "name": "no-tunnel",
-          "type": "boolean"
-        },
         "path": {
           "description": "The path to your app directory.",
           "env": "SHOPIFY_FLAG_PATH",
@@ -1658,14 +1628,6 @@
           "name": "source",
           "type": "option"
         },
-        "stable": {
-          "allowNo": false,
-          "description": "Use the legacy Ruby implementation for managing theme app extensions.",
-          "env": "SHOPIFY_FLAG_LEGACY",
-          "hidden": true,
-          "name": "stable",
-          "type": "boolean"
-        },
         "status": {
           "description": "Filters output to the specified status (success or failure).",
           "env": "SHOPIFY_FLAG_STATUS",