Skip to content

Commit

Permalink
Remove app prompt for both Partners and App Management apps
Browse files Browse the repository at this point in the history
  • Loading branch information
jamieguerrero committed Jan 10, 2025
1 parent 1547704 commit 4411167
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ async function handleUpdatingOfPartnerUrls(
// When running dev app urls are pushed directly to API Client config instead of creating a new app version
// so current app version and API Client config will have diferent url values.
if (shouldUpdateURLs) await updateURLs(newURLs, apiKey, developerPlatformClient, localApp)
await outputUpdateURLsResult(shouldUpdateURLs, newURLs, remoteApp, localApp, developerPlatformClient)
await outputUpdateURLsResult(shouldUpdateURLs, newURLs, remoteApp, localApp)
}
}
return shouldUpdateURLs
Expand Down
14 changes: 1 addition & 13 deletions packages/app/src/cli/services/dev/ui.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {Dev, DevProps} from './ui/components/Dev.js'
import {AppInterface, isCurrentAppSchema} from '../../models/app/app.js'
import {OrganizationApp} from '../../models/organization.js'
import {getAppConfigurationShorthand} from '../../models/app/loader.js'
import {ClientName, DeveloperPlatformClient} from '../../utilities/developer-platform-client.js'
import React from 'react'
import {partnersFqdn} from '@shopify/cli-kit/node/context/fqdn'
import {render, renderInfo} from '@shopify/cli-kit/node/ui'
Expand All @@ -18,20 +17,9 @@ export async function outputUpdateURLsResult(
urls: PartnersURLs,
remoteApp: OrganizationApp,
localApp: AppInterface,
developerPlatformClient?: DeveloperPlatformClient,
) {
const usingAppManagementClient = developerPlatformClient?.clientName === ClientName.AppManagement
const dashboardURL = await partnersURL(remoteApp.organizationId, remoteApp.id)
if (remoteApp.newApp && !usingAppManagementClient) {
renderInfo({
headline: `For your convenience, we've given your app a default URL: ${urls.applicationUrl}.`,
body: [
"You can update your app's URL anytime in the",
dashboardURL,
'But once your app is live, updating its URL will disrupt user access.',
],
})
} else if (!updated) {
if (!updated) {
if (isCurrentAppSchema(localApp.configuration)) {
const fileName = basename(localApp.configuration.path)
const configName = getAppConfigurationShorthand(fileName)
Expand Down

0 comments on commit 4411167

Please sign in to comment.