misc: add path and/or other details when throwing

- Added the path and/or other details when throwing in a provider, to more easily identify _which_ series/episode is throwing if the stack trace and/or error message is generic/useless.
ShokoAnime · Sep 22, 2024 · 5ea5cb1 · 5ea5cb1
1 parent 70bfe17
commit 5ea5cb1
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 7 deletions.
diff --git a/Shokofin/Providers/BoxSetProvider.cs b/Shokofin/Providers/BoxSetProvider.cs
@@ -50,7 +50,7 @@ public async Task<MetadataResult<BoxSet>> GetMetadata(BoxSetInfo info, Cancellat
             return new();
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            Logger.LogError(ex, "Threw unexpectedly while refreshing {Path}; {Message}", info.Path, ex.Message);
             return new MetadataResult<BoxSet>();
         }
     }

diff --git a/Shokofin/Providers/EpisodeProvider.cs b/Shokofin/Providers/EpisodeProvider.cs
@@ -86,7 +86,15 @@ public async Task<MetadataResult<Episode>> GetMetadata(EpisodeInfo info, Cancell
             return result;
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            if (info.IsMissingEpisode || string.IsNullOrEmpty(info.Path)) {
+                if (!info.TryGetProviderId(ShokoEpisodeId.Name, out var episodeId))
+                    episodeId = null;
+                Logger.LogError(ex, "Threw unexpectedly while refreshing a missing episode; {Message} (Episode={EpisodeId})", ex.Message, episodeId);
+            }
+            else {
+                Logger.LogError(ex, "Threw unexpectedly while refreshing {Path}: {Message}", info.Path, info.IsMissingEpisode);
+            }
+
             return new MetadataResult<Episode>();
         }
         finally {

diff --git a/Shokofin/Providers/MovieProvider.cs b/Shokofin/Providers/MovieProvider.cs
@@ -83,7 +83,7 @@ public async Task<MetadataResult<Movie>> GetMetadata(MovieInfo info, Cancellatio
             return result;
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            Logger.LogError(ex, "Threw unexpectedly while refreshing {Path}; {Message}", info.Path, ex.Message);
             return new MetadataResult<Movie>();
         }
         finally {

diff --git a/Shokofin/Providers/SeasonProvider.cs b/Shokofin/Providers/SeasonProvider.cs
@@ -91,7 +91,7 @@ public async Task<MetadataResult<Season>> GetMetadata(SeasonInfo info, Cancellat
             return result;
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            Logger.LogError(ex, "Threw unexpectedly while refreshing season {SeasonNumber}; {Message} (Path={Path},Series={SeriesId})", info.IndexNumber, ex.Message, info.Path, seriesId);
             return new MetadataResult<Season>();
         }
         finally {

diff --git a/Shokofin/Providers/SeriesProvider.cs b/Shokofin/Providers/SeriesProvider.cs
@@ -95,7 +95,7 @@ public async Task<MetadataResult<Series>> GetMetadata(SeriesInfo info, Cancellat
             return result;
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            Logger.LogError(ex, "Threw unexpectedly while refreshing {Path}; {Message}", info.Path, ex.Message);
             return new MetadataResult<Series>();
         }
         finally {

diff --git a/Shokofin/Providers/TrailerProvider.cs b/Shokofin/Providers/TrailerProvider.cs
@@ -68,7 +68,7 @@ public async Task<MetadataResult<Trailer>> GetMetadata(TrailerInfo info, Cancell
             return result;
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            Logger.LogError(ex, "Threw unexpectedly while refreshing path {Path}; {Message}", info.Path, ex.Message);
             return new MetadataResult<Trailer>();
         }
         finally {

diff --git a/Shokofin/Providers/VideoProvider.cs b/Shokofin/Providers/VideoProvider.cs
@@ -68,7 +68,7 @@ public async Task<MetadataResult<Video>> GetMetadata(ItemLookupInfo info, Cancel
             return result;
         }
         catch (Exception ex) {
-            Logger.LogError(ex, "Threw unexpectedly; {Message}", ex.Message);
+            Logger.LogError(ex, "Threw unexpectedly while refreshing {Path}; {Message}", info.Path, ex.Message);
             return new MetadataResult<Video>();
         }
         finally {