Work on CheckForTraktTokenUpdate #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have it read the expiration time from settings and not just refresh the token every 24h, only if it's going to expire in 45 days
|
I could not test expiration and renewal yet. But at least I get a proper output of the token valid date in the logs while it's still valid and it does not try renewing it until a certain amount of time (45 days / 1/2 of the validity) If someone can look into this code and optimize it if needed (or give feedback), that would be great |
da3dsoul
reviewed
Jan 15, 2024
| var expirationDate = DateTimeOffset.FromUnixTimeSeconds(long.Parse(settings.TraktTv.TokenExpirationDate)).DateTime; | ||
|
|
||
| // Check if force refresh is requested or the token is expired | ||
| if (forceRefresh || DateTime.Now.Add(TimeSpan.FromDays(45)) >= expirationDate) |
There was a problem hiding this comment.
https://discord.com/channels/96234011612958720/1148092356592160768/1195127627397214331
Initially I had it set to 30 days, but half would be 45 days so I set this. We can set it to whatever is fine
There was a problem hiding this comment.
Token lifetime - it's 90 days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have it read the expiration time from settings and not just refresh the token every 24h, only if it's going to expire in 45 days