Skip to content

Concurrency data handling#8

Closed
Shirley125 wants to merge 7 commits into
async_schedulefrom
cursor/concurrency-data-handling-78a8
Closed

Concurrency data handling#8
Shirley125 wants to merge 7 commits into
async_schedulefrom
cursor/concurrency-data-handling-78a8

Conversation

@Shirley125
Copy link
Copy Markdown
Owner

Purpose

This PR addresses a race condition in the shared memory (SHM) connector that caused cannot mmap an empty file and MessagePack data is malformed errors under high concurrency. The issue occurred when the consumer attempted to read from an SHM segment before the producer had fully written the data or properly sized the segment.

Test Plan

The fix was developed to resolve concurrency issues observed with PR vllm-project#951. To validate, run the system under high concurrency and verify that the previously reported errors (cannot mmap an empty file, MessagePack data is malformed) no longer occur.

Test Result

Unit tests passed. The implemented changes are designed to prevent the reported concurrency errors by ensuring data integrity and proper synchronization during shared memory communication.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md


Open in Cursor Open in Web

Shirley125 and others added 4 commits January 26, 2026 13:19
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
Co-authored-by: Bhanu068 <voutharoja.bhanu06@gmail.com>
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
…eader and retry logic

Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 27, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

cursoragent and others added 2 commits January 27, 2026 03:52
Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
… clearing scheduler cache

Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
@Shirley125 Shirley125 force-pushed the async_schedule branch 12 times, most recently from 681aa2c to 0ae7092 Compare February 11, 2026 03:52
@Shirley125 Shirley125 force-pushed the async_schedule branch 4 times, most recently from 4d0c3cc to d02287d Compare February 12, 2026 05:12
@Shirley125 Shirley125 closed this Feb 13, 2026
@Shirley125 Shirley125 deleted the cursor/concurrency-data-handling-78a8 branch February 13, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants