Concurrency data handling#8
Closed
Shirley125 wants to merge 7 commits into
Closed
Conversation
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn> Co-authored-by: Bhanu068 <voutharoja.bhanu06@gmail.com>
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
…eader and retry logic Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
… clearing scheduler cache Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
115f72b to
4af5b4d
Compare
Co-authored-by: weifusheng33 <weifusheng33@gmail.com>
681aa2c to
0ae7092
Compare
4d0c3cc to
d02287d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses a race condition in the shared memory (SHM) connector that caused
cannot mmap an empty fileandMessagePack data is malformederrors under high concurrency. The issue occurred when the consumer attempted to read from an SHM segment before the producer had fully written the data or properly sized the segment.Test Plan
The fix was developed to resolve concurrency issues observed with PR vllm-project#951. To validate, run the system under high concurrency and verify that the previously reported errors (
cannot mmap an empty file,MessagePack data is malformed) no longer occur.Test Result
Unit tests passed. The implemented changes are designed to prevent the reported concurrency errors by ensuring data integrity and proper synchronization during shared memory communication.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md