Fixed fuse setxattr body length is not right error #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastixx
reviewed
Feb 15, 2023
| // setxattr "size" field specifies size of only "Value" part of data | ||
| if setxattr_in.size as usize != data.len() { | ||
| error!( | ||
| "fuse_setxattr_in value field data length is not right, request unique {} setxattr_in.size={} data.len={}", request.unique, setxattr_in.size, data.len()); |
There was a problem hiding this comment.
Suggested change
| "fuse_setxattr_in value field data length is not right, request unique {} setxattr_in.size={} data.len={}", request.unique, setxattr_in.size, data.len()); | |
| "fuse_setxattr_in value field data length is not right, request unique {} setxattr_in.size={} data.len={}", | |
| request.unique, | |
| setxattr_in.size, | |
| data.len() | |
| ); |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error "body length is not right" when handling any FUSE_SETXATTR request.
Before fix, we checked size of full payload "Name"+"Value", but setxattr.size field specifies only size of "Value" field.
Moved size check procedure down to proper place after payload splitting to "Name" and "Value".
Now we compare setxattr.size field with size of "Value" field.