-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tooltip handling #22
Conversation
Gametooltip saw a lot changes in 10.0.2 - unfortunately this broke the addon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! There are a few lint issues that need fixing, I've left a review comment on how to address it.
Are you able to test if these changes work in the Classic and WotLK clients as well? Otherwise I should be able to test it on Sunday evening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the changes in Classic and Wrath Classic now and the new tooltip code does not exist there yet so there will need to be some code checking the WOW_PROJECT_ID
and only use the new code on retail.
Do you feel comfortable adding those changes? I can also add them after the merge if that works better.
Hello. Any ETA on when this would get merged? |
There are the issued marked above that need fixing, but I might just adjust them myself for this PR later just to get it shipped out since it is important for fixing compatibility. |
Gametooltip saw a lot changes in 10.0.2 - unfortunately this broke the addon.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: