Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Rad Azzouz <[email protected]>
Co-Authored-By: David Schreiber-Ranner <[email protected]>
  • Loading branch information
3 people authored Nov 4, 2019
1 parent b1a4e2c commit b998c3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ const styles = StyleSheet.create({
#### Running Native Catalog
See [here](https://github.com/PSPDFKit/react-native/tree/master/samples/NativeCatalog)
Take a look at the [instructions to get started here](https://github.com/PSPDFKit/react-native/tree/master/samples/NativeCatalog/README.md)
#### Configuration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ protected PdfView createViewInstance(@NonNull ThemedReactContext reactContext) {
if (currentActivity instanceof FragmentActivity) {
FragmentActivity fragmentActivity = (FragmentActivity) currentActivity;

// You can create a PdfView in your own view manager and use all the work our wrapper already does.
// You can create a PdfView in your own view manager to reuse all the work our wrapper already does.
PdfView pdfView = new PdfView(reactContext);

// Make sure to inject all the classes the view needs to function.
Expand Down Expand Up @@ -183,7 +183,7 @@ private void performInkSigning(@NonNull PdfView pdfView) {
.subscribe(pdfFragment -> {
// We got our fragment.
PdfDocument document = pdfFragment.getDocument();
// We have a element with the name EMPLOYEE SIGNATURE in the document, grab a reference here.
// We have an element with the name EMPLOYEE SIGNATURE in the document. Grab a reference here.
SignatureFormElement signatureFormElement = (SignatureFormElement) document.getFormProvider().getFormElementWithName("EMPLOYEE SIGNATURE");
// Now we can display the signature picker.
SignaturePickerFragment.show(pdfFragment.getFragmentManager(), new SignaturePickerFragment.OnSignaturePickedListener() {
Expand Down

0 comments on commit b998c3e

Please sign in to comment.