Implentation of Muambator Service #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
| using ShareBook.Helper; | |||
| using ShareBook.Service.Muambator; | |||
There was a problem hiding this comment.
Acho que o controller não precisa nem saber que existe esse serviço.
There was a problem hiding this comment.
Posso apagar. Realmente nao e necessario
| "RollbarEnvironment": "local", | ||
| "Muambator": { | ||
| "Token": "" | ||
| } |
There was a problem hiding this comment.
O que acha de termos um parâmetro active = true/false?
Daí a gente desabilita facilmente nos ambientes de DEV e STG. E a gente teria uma carta na manga pra desabilitar rápido em prod numa situação extrema.
| @@ -211,6 +215,8 @@ public void InformTrackingNumber(Guid bookId, string trackingNumber) | |||
| if (winnerBookUser == null) | |||
| throw new ShareBookException("Vencedor ainda não foi escolhido"); | |||
|
|
|||
| _muambatorService.AddPackageToTrackerAsync(winnerBookUser.User.Email, trackingNumber); | |||
There was a problem hiding this comment.
Aí aqui vc colocaria um if pra verificar se está ativo ou não. (sugestão)
| @@ -0,0 +1,15 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Data transfer object. No caso um modelo de transport. Ele nao se encaixa como VM dentro desta arquitetura. E tb nao e uma entidade de negocio,
raffacabofrio
requested changes
Oct 3, 2019
raffacabofrio
approved these changes
Oct 4, 2019
danielaloisio
approved these changes
Oct 4, 2019
raffacabofrio
pushed a commit
to raffacabofrio/sharebook-backend
that referenced
this pull request
Dec 4, 2021
…d_yarn/acorn-6.4.1 Bump acorn from 6.4.0 to 6.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development of service which consumes the Muambator service to create a notification about the tracked package.