-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add path-based SVG rendering with RLE encoding to reduce file size and memory usage #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e8b7054
Optimize SVGs
Shane32 5be3566
Apply suggestion from coderabbit
Shane32 96159c8
Use invariant culture
Shane32 c640bec
fix
Shane32 1e363d7
Update
Shane32 333d04f
Fix
Shane32 17a05f3
Add test for new method
Shane32 e665c56
Add tests
Shane32 3f6dd5b
Final comment updates
Shane32 b2c8d19
update
Shane32 8ad2c67
update comment
Shane32 b2b37b4
Convert to regular string
Shane32 e87b31c
Add invariant culture formatting methods for StringBuilder appends
Shane32 58789f5
Update AppendInvariant method to use G7 precision for float formatting
Shane32 790d32f
Update ToStr method to use G7 precision for float formatting
Shane32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
229 changes: 3 additions & 226 deletions
229
QRCoderTests/SvgQRCodeRendererTests.can_render_svg_qrcode.approved.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
80 changes: 3 additions & 77 deletions
80
QRCoderTests/SvgQRCodeRendererTests.can_render_svg_qrcode_from_helper.approved.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
124 changes: 3 additions & 121 deletions
124
QRCoderTests/SvgQRCodeRendererTests.can_render_svg_qrcode_simple.approved.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this savings are impressive 👍🏻