Skip to content

Enable SVG tests #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shane32 merged 2 commits into from
Oct 7, 2025
Merged

Enable SVG tests #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d36bb1
Enable SVG tests
Shane32 Oct 7, 2025
d05cd81
Merge branch 'master' into enable_svg_tests
Shane32 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions QRCoderTests/SvgQRCodeRendererTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public void can_render_svg_qrcode_without_quietzones_hex()
svg.ShouldMatchApproved(x => x.NoDiff().WithFileExtension("svg"));
}

#if SYSTEM_DRAWING && !NET5_0_OR_GREATER // .NET 5+ does not encode PNG images in a deterministic way, so the hash may be different across different runs
#if SYSTEM_DRAWING
[Fact]
public void can_render_svg_qrcode_with_png_logo_bitmap()
{
Expand All @@ -83,7 +83,7 @@ public void can_render_svg_qrcode_with_png_logo_bitmap()
RegexOptions.IgnoreCase);
var match = regex.Match(svg);
if (!match.Success || match.Groups.Count < 2)
throw new Exception("Could not find embedded image data in SVG output.");
throw new InvalidOperationException("Could not find embedded image data in SVG output.");
var base64Data = match.Groups[1].Value;
var imageData = Convert.FromBase64String(base64Data);
imageData.ShouldMatchApprovedImage(discriminator: "embeddedLogo");
Expand Down Expand Up @@ -111,7 +111,7 @@ public void can_render_svg_qrcode_with_png_logo_bitmap_without_background()
RegexOptions.IgnoreCase);
var match = regex.Match(svg);
if (!match.Success || match.Groups.Count < 2)
throw new Exception("Could not find embedded image data in SVG output.");
throw new InvalidOperationException("Could not find embedded image data in SVG output.");
var base64Data = match.Groups[1].Value;
var imageData = Convert.FromBase64String(base64Data);
imageData.ShouldMatchApprovedImage(discriminator: "embeddedLogo");
Expand Down Expand Up @@ -139,7 +139,7 @@ public void can_render_svg_qrcode_with_png_logo_bitmap_without_quietzones()
RegexOptions.IgnoreCase);
var match = regex.Match(svg);
if (!match.Success || match.Groups.Count < 2)
throw new Exception("Could not find embedded image data in SVG output.");
throw new InvalidOperationException("Could not find embedded image data in SVG output.");
var base64Data = match.Groups[1].Value;
var imageData = Convert.FromBase64String(base64Data);
imageData.ShouldMatchApprovedImage(discriminator: "embeddedLogo");
Expand Down