Skip to content

Add postscript renderer optimizations #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shane32 merged 2 commits into from
Oct 7, 2025
Merged

Add postscript renderer optimizations #651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a427f08
Add postscript optimizations
Shane32 Oct 7, 2025
807653d
update
Shane32 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions QRCoder/PostscriptQRCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#if !NETSTANDARD1_3
using System.Drawing;
using System.Text;
using static QRCoder.QRCodeGenerator;

namespace QRCoder;
Expand Down Expand Up @@ -100,11 +101,20 @@ public string GetGraphic(Size viewBox, Color darkColor, Color lightColor, bool d
var drawableModulesCount = QrCodeData.ModuleMatrix.Count - (drawQuietZones ? 0 : offset * 2);
var pointsPerModule = (double)Math.Min(viewBox.Width, viewBox.Height) / (double)drawableModulesCount;

string psFile = string.Format(CultureInfo.InvariantCulture, PS_HEADER, new object[] {
// Estimate capacity: PS_HEADER + PS_FUNCTIONS + PS_FOOTER + matrix content
// Each module generates 2 chars ("f " or "b "), plus newlines
// Add 200 characters for embedded numbers
var estimatedCapacity = PS_HEADER.Length + PS_FUNCTIONS.Length + PS_FOOTER.Length +
(drawableModulesCount * drawableModulesCount * 2) + // modules
drawableModulesCount * 3 + // newlines
100;
var sb = new StringBuilder(estimatedCapacity);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

sb.AppendFormat(CultureInfo.InvariantCulture, PS_HEADER, new object[] {
CleanSvgVal(viewBox.Width), CleanSvgVal(pointsPerModule),
epsFormat ? "EPSF-3.0" : string.Empty
});
psFile += string.Format(CultureInfo.InvariantCulture, PS_FUNCTIONS, new object[] {
sb.AppendFormat(CultureInfo.InvariantCulture, PS_FUNCTIONS, new object[] {
CleanSvgVal(darkColor.R /255.0), CleanSvgVal(darkColor.G /255.0), CleanSvgVal(darkColor.B /255.0),
CleanSvgVal(lightColor.R /255.0), CleanSvgVal(lightColor.G /255.0), CleanSvgVal(lightColor.B /255.0),
drawableModulesCount
Expand All @@ -113,22 +123,23 @@ public string GetGraphic(Size viewBox, Color darkColor, Color lightColor, bool d
for (int xi = offset; xi < offset + drawableModulesCount; xi++)
{
if (xi > offset)
psFile += "nl\n";
sb.Append("nl\n");
for (int yi = offset; yi < offset + drawableModulesCount; yi++)
{
psFile += (QrCodeData.ModuleMatrix[xi][yi] ? "f " : "b ");
sb.Append(QrCodeData.ModuleMatrix[xi][yi] ? "f " : "b ");
}
psFile += "\n";
}
return psFile + PS_FOOTER;
sb.Append('\n');
sb.Append(PS_FOOTER);
return sb.ToString();
}

/// <summary>
/// Cleans double values for international use/formats.
/// </summary>
/// <param name="input">The input double value.</param>
/// <returns>Returns the cleaned string representation of the double value.</returns>
private static string CleanSvgVal(double input) => input.ToString(System.Globalization.CultureInfo.InvariantCulture);
/// <returns>Returns the cleaned string representation of the double value, with a maximum of 7 significant digits.</returns>
private static string CleanSvgVal(double input) => input.ToString("G7", CultureInfo.InvariantCulture);

// Note: line terminations here will encode differently based on which platform QRCoder was compiled on (CRLF vs LF);
// however, PostScript interpreters should handle both equally well.
Expand Down
96 changes: 32 additions & 64 deletions QRCoderTests/PostscriptQRCodeRendererTests.can_render_postscript_qrcode_colors.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,70 +50,38 @@ grestore
gsave
sc sc scale
0 33 1 sub translate
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b f f f f f f f b f b f b f b b b f b f f f f f f f b b b b
nl
b b b b f b b b b b f b b f f f f b b b b b f b b b b b f b b b b
nl
b b b b f b f f f b f b f f f b b f f b b b f b f f f b f b b b b
nl
b b b b f b f f f b f b f f f b f f f f f b f b f f f b f b b b b
nl
b b b b f b f f f b f b f b b f f b b f f b f b f f f b f b b b b
nl
b b b b f b b b b b f b b b f f b b b b f b f b b b b b f b b b b
nl
b b b b f f f f f f f b f b f b f b f b f b f f f f f f f b b b b
nl
b b b b b b b b b b b b b b f b f b b b b b b b b b b b b b b b b
nl
b b b b f f f f b b f b f b f f b b f b f f b b f f f b f b b b b
nl
b b b b f f b f f f b f f b f b f b f b b b b b b f f b b b b b b
nl
b b b b b f f f f f f b b f f f f b b b f f b f f f b b b b b b b
nl
b b b b b b b f b f b b f f f f f f b f f b b f b f f b b b b b b
nl
b b b b f b f f b f f f b f f f b f b b b f f b f b f b b b b b b
nl
b b b b b f f f b f b b b b b b b b f f f b f f f b b f f b b b b
nl
b b b b b f b b b f f f f f b b f f b b b b b f b f b f b b b b b
nl
b b b b f b f f b f b f f f f f f b f b b f f b b f b b f b b b b
nl
b b b b b b f b f f f f f f f f b f f b f f f f f b f b b b b b b
nl
b b b b b b b b b b b b f f b f b f b b f b b b f b f f b b b b b
nl
b b b b f f f f f f f b b b b b b b b b f b f b f f b f f b b b b
nl
b b b b f b b b b b f b b f f b b b f f f b b b f f b b f b b b b
nl
b b b b f b f f f b f b b b f b f b b b f f f f f b b b f b b b b
nl
b b b b f b f f f b f b f b f f f b f b b f f b f f f f f b b b b
nl
b b b b f b f f f b f b f b b f b b f b f b f b f f b f b b b b b
nl
b b b b f b b b b b f b f f f f b f f b b f b b f f f b b b b b b
nl
b b b b f f f f f f f b f b b b b f b b b f f b b b f f f b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b f f f f f f f b f b f b f b b b f b f f f f f f f b b b b nl
b b b b f b b b b b f b b f f f f b b b b b f b b b b b f b b b b nl
b b b b f b f f f b f b f f f b b f f b b b f b f f f b f b b b b nl
b b b b f b f f f b f b f f f b f f f f f b f b f f f b f b b b b nl
b b b b f b f f f b f b f b b f f b b f f b f b f f f b f b b b b nl
b b b b f b b b b b f b b b f f b b b b f b f b b b b b f b b b b nl
b b b b f f f f f f f b f b f b f b f b f b f f f f f f f b b b b nl
b b b b b b b b b b b b b b f b f b b b b b b b b b b b b b b b b nl
b b b b f f f f b b f b f b f f b b f b f f b b f f f b f b b b b nl
b b b b f f b f f f b f f b f b f b f b b b b b b f f b b b b b b nl
b b b b b f f f f f f b b f f f f b b b f f b f f f b b b b b b b nl
b b b b b b b f b f b b f f f f f f b f f b b f b f f b b b b b b nl
b b b b f b f f b f f f b f f f b f b b b f f b f b f b b b b b b nl
b b b b b f f f b f b b b b b b b b f f f b f f f b b f f b b b b nl
b b b b b f b b b f f f f f b b f f b b b b b f b f b f b b b b b nl
b b b b f b f f b f b f f f f f f b f b b f f b b f b b f b b b b nl
b b b b b b f b f f f f f f f f b f f b f f f f f b f b b b b b b nl
b b b b b b b b b b b b f f b f b f b b f b b b f b f f b b b b b nl
b b b b f f f f f f f b b b b b b b b b f b f b f f b f f b b b b nl
b b b b f b b b b b f b b f f b b b f f f b b b f f b b f b b b b nl
b b b b f b f f f b f b b b f b f b b b f f f f f b b b f b b b b nl
b b b b f b f f f b f b f b f f f b f b b f f b f f f f f b b b b nl
b b b b f b f f f b f b f b b f b b f b f b f b f f b f b b b b b nl
b b b b f b b b b b f b f f f f b f f b b f b b f f f b b b b b b nl
b b b b f f f f f f f b f b b b b f b b b f f b b b f f f b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
%%EndBody
grestore
Expand Down
96 changes: 32 additions & 64 deletions QRCoderTests/PostscriptQRCodeRendererTests.can_render_postscript_qrcode_eps.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,70 +50,38 @@ grestore
gsave
sc sc scale
0 33 1 sub translate
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b f f f f f f f b f b f b f b b b f b f f f f f f f b b b b
nl
b b b b f b b b b b f b b f f f f b b b b b f b b b b b f b b b b
nl
b b b b f b f f f b f b f f f b b f f b b b f b f f f b f b b b b
nl
b b b b f b f f f b f b f f f b f f f f f b f b f f f b f b b b b
nl
b b b b f b f f f b f b f b b f f b b f f b f b f f f b f b b b b
nl
b b b b f b b b b b f b b b f f b b b b f b f b b b b b f b b b b
nl
b b b b f f f f f f f b f b f b f b f b f b f f f f f f f b b b b
nl
b b b b b b b b b b b b b b f b f b b b b b b b b b b b b b b b b
nl
b b b b f f f f b b f b f b f f b b f b f f b b f f f b f b b b b
nl
b b b b f f b f f f b f f b f b f b f b b b b b b f f b b b b b b
nl
b b b b b f f f f f f b b f f f f b b b f f b f f f b b b b b b b
nl
b b b b b b b f b f b b f f f f f f b f f b b f b f f b b b b b b
nl
b b b b f b f f b f f f b f f f b f b b b f f b f b f b b b b b b
nl
b b b b b f f f b f b b b b b b b b f f f b f f f b b f f b b b b
nl
b b b b b f b b b f f f f f b b f f b b b b b f b f b f b b b b b
nl
b b b b f b f f b f b f f f f f f b f b b f f b b f b b f b b b b
nl
b b b b b b f b f f f f f f f f b f f b f f f f f b f b b b b b b
nl
b b b b b b b b b b b b f f b f b f b b f b b b f b f f b b b b b
nl
b b b b f f f f f f f b b b b b b b b b f b f b f f b f f b b b b
nl
b b b b f b b b b b f b b f f b b b f f f b b b f f b b f b b b b
nl
b b b b f b f f f b f b b b f b f b b b f f f f f b b b f b b b b
nl
b b b b f b f f f b f b f b f f f b f b b f f b f f f f f b b b b
nl
b b b b f b f f f b f b f b b f b b f b f b f b f f b f b b b b b
nl
b b b b f b b b b b f b f f f f b f f b b f b b f f f b b b b b b
nl
b b b b f f f f f f f b f b b b b f b b b f f b b b f f f b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b f f f f f f f b f b f b f b b b f b f f f f f f f b b b b nl
b b b b f b b b b b f b b f f f f b b b b b f b b b b b f b b b b nl
b b b b f b f f f b f b f f f b b f f b b b f b f f f b f b b b b nl
b b b b f b f f f b f b f f f b f f f f f b f b f f f b f b b b b nl
b b b b f b f f f b f b f b b f f b b f f b f b f f f b f b b b b nl
b b b b f b b b b b f b b b f f b b b b f b f b b b b b f b b b b nl
b b b b f f f f f f f b f b f b f b f b f b f f f f f f f b b b b nl
b b b b b b b b b b b b b b f b f b b b b b b b b b b b b b b b b nl
b b b b f f f f b b f b f b f f b b f b f f b b f f f b f b b b b nl
b b b b f f b f f f b f f b f b f b f b b b b b b f f b b b b b b nl
b b b b b f f f f f f b b f f f f b b b f f b f f f b b b b b b b nl
b b b b b b b f b f b b f f f f f f b f f b b f b f f b b b b b b nl
b b b b f b f f b f f f b f f f b f b b b f f b f b f b b b b b b nl
b b b b b f f f b f b b b b b b b b f f f b f f f b b f f b b b b nl
b b b b b f b b b f f f f f b b f f b b b b b f b f b f b b b b b nl
b b b b f b f f b f b f f f f f f b f b b f f b b f b b f b b b b nl
b b b b b b f b f f f f f f f f b f f b f f f f f b f b b b b b b nl
b b b b b b b b b b b b f f b f b f b b f b b b f b f f b b b b b nl
b b b b f f f f f f f b b b b b b b b b f b f b f f b f f b b b b nl
b b b b f b b b b b f b b f f b b b f f f b b b f f b b f b b b b nl
b b b b f b f f f b f b b b f b f b b b f f f f f b b b f b b b b nl
b b b b f b f f f b f b f b f f f b f b b f f b f f f f f b b b b nl
b b b b f b f f f b f b f b b f b b f b f b f b f f b f b b b b b nl
b b b b f b b b b b f b f f f f b f f b b f b b f f f b b b b b b nl
b b b b f f f f f f f b f b b b b f b b b f f b b b f f f b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
%%EndBody
grestore
Expand Down
96 changes: 32 additions & 64 deletions QRCoderTests/PostscriptQRCodeRendererTests.can_render_postscript_qrcode_simple.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,70 +50,38 @@ grestore
gsave
sc sc scale
0 33 1 sub translate
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b f f f f f f f b f b f b f b b b f b f f f f f f f b b b b
nl
b b b b f b b b b b f b b f f f f b b b b b f b b b b b f b b b b
nl
b b b b f b f f f b f b f f f b b f f b b b f b f f f b f b b b b
nl
b b b b f b f f f b f b f f f b f f f f f b f b f f f b f b b b b
nl
b b b b f b f f f b f b f b b f f b b f f b f b f f f b f b b b b
nl
b b b b f b b b b b f b b b f f b b b b f b f b b b b b f b b b b
nl
b b b b f f f f f f f b f b f b f b f b f b f f f f f f f b b b b
nl
b b b b b b b b b b b b b b f b f b b b b b b b b b b b b b b b b
nl
b b b b f f f f b b f b f b f f b b f b f f b b f f f b f b b b b
nl
b b b b f f b f f f b f f b f b f b f b b b b b b f f b b b b b b
nl
b b b b b f f f f f f b b f f f f b b b f f b f f f b b b b b b b
nl
b b b b b b b f b f b b f f f f f f b f f b b f b f f b b b b b b
nl
b b b b f b f f b f f f b f f f b f b b b f f b f b f b b b b b b
nl
b b b b b f f f b f b b b b b b b b f f f b f f f b b f f b b b b
nl
b b b b b f b b b f f f f f b b f f b b b b b f b f b f b b b b b
nl
b b b b f b f f b f b f f f f f f b f b b f f b b f b b f b b b b
nl
b b b b b b f b f f f f f f f f b f f b f f f f f b f b b b b b b
nl
b b b b b b b b b b b b f f b f b f b b f b b b f b f f b b b b b
nl
b b b b f f f f f f f b b b b b b b b b f b f b f f b f f b b b b
nl
b b b b f b b b b b f b b f f b b b f f f b b b f f b b f b b b b
nl
b b b b f b f f f b f b b b f b f b b b f f f f f b b b f b b b b
nl
b b b b f b f f f b f b f b f f f b f b b f f b f f f f f b b b b
nl
b b b b f b f f f b f b f b b f b b f b f b f b f f b f b b b b b
nl
b b b b f b b b b b f b f f f f b f f b b f b b f f f b b b b b b
nl
b b b b f f f f f f f b f b b b b f b b b f f b b b f f f b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b f f f f f f f b f b f b f b b b f b f f f f f f f b b b b nl
b b b b f b b b b b f b b f f f f b b b b b f b b b b b f b b b b nl
b b b b f b f f f b f b f f f b b f f b b b f b f f f b f b b b b nl
b b b b f b f f f b f b f f f b f f f f f b f b f f f b f b b b b nl
b b b b f b f f f b f b f b b f f b b f f b f b f f f b f b b b b nl
b b b b f b b b b b f b b b f f b b b b f b f b b b b b f b b b b nl
b b b b f f f f f f f b f b f b f b f b f b f f f f f f f b b b b nl
b b b b b b b b b b b b b b f b f b b b b b b b b b b b b b b b b nl
b b b b f f f f b b f b f b f f b b f b f f b b f f f b f b b b b nl
b b b b f f b f f f b f f b f b f b f b b b b b b f f b b b b b b nl
b b b b b f f f f f f b b f f f f b b b f f b f f f b b b b b b b nl
b b b b b b b f b f b b f f f f f f b f f b b f b f f b b b b b b nl
b b b b f b f f b f f f b f f f b f b b b f f b f b f b b b b b b nl
b b b b b f f f b f b b b b b b b b f f f b f f f b b f f b b b b nl
b b b b b f b b b f f f f f b b f f b b b b b f b f b f b b b b b nl
b b b b f b f f b f b f f f f f f b f b b f f b b f b b f b b b b nl
b b b b b b f b f f f f f f f f b f f b f f f f f b f b b b b b b nl
b b b b b b b b b b b b f f b f b f b b f b b b f b f f b b b b b nl
b b b b f f f f f f f b b b b b b b b b f b f b f f b f f b b b b nl
b b b b f b b b b b f b b f f b b b f f f b b b f f b b f b b b b nl
b b b b f b f f f b f b b b f b f b b b f f f f f b b b f b b b b nl
b b b b f b f f f b f b f b f f f b f b b f f b f f f f f b b b b nl
b b b b f b f f f b f b f b b f b b f b f b f b f f b f b b b b b nl
b b b b f b b b b b f b f f f f b f f b b f b b f f f b b b b b b nl
b b b b f f f f f f f b f b b b b f b b b f f b b b f f f b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b nl
b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
%%EndBody
grestore
Expand Down
Loading
Loading