Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clearBeforeTypingMode flag and deprecating old flags #1752

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

AhmdZanoon
Copy link
Contributor

  • new flag added to control clear before typing
    key clearBeforeTypingMode
    possible values :
    native ( to clear using native selenium clear )
    backspace ( to delete letter by letter )
    off ( no clear before typing )
  • deprecating old flags
    attemptClearBeforeTyping , attemptClearBeforeTypingUsingBackspace

adding new property clearMode
it can be native , backspace , off

setting override method to support backward compatibility
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.69%. Comparing base (022f84c) to head (8dfdb1a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/shaft/gui/element/internal/Actions.java 42.85% 3 Missing and 1 partial ⚠️
...om/shaft/properties/internal/PropertiesHelper.java 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1752      +/-   ##
============================================
- Coverage     53.26%   51.69%   -1.57%     
+ Complexity     1345     1307      -38     
============================================
  Files           113      113              
  Lines         10176    10186      +10     
  Branches        993      993              
============================================
- Hits           5420     5266     -154     
- Misses         4108     4290     +182     
+ Partials        648      630      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohabMohie MohabMohie merged commit fbb38c8 into main Oct 1, 2024
16 of 18 checks passed
@MohabMohie MohabMohie deleted the clearMode branch October 1, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants