-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding MultiAgent Utilities #323
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 0927001 into c3ef4d9 - view on LGTM.com new alerts:
|
Looks pretty good. |
This pull request introduces 2 alerts when merging daa8b2a into c3ef4d9 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 44db72e into c3ef4d9 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging d8cf1a9 into c3ef4d9 - view on LGTM.com new alerts:
|
This pull request introduces 5 alerts when merging 1365585 into c3ef4d9 - view on LGTM.com new alerts:
|
@@ -106,3 +106,107 @@ def close(self) -> None: | |||
Closes environment | |||
""" | |||
self.env.close() | |||
|
|||
|
|||
class MultiGymWrapper(gym.Wrapper): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the difference between this and a normal Wrapper? Cant you use a TorchWrapper instead of creating this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a template, I haven't added anything yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you install pre-commit
? You can see the instructions in Contributing.md
This pull request introduces 5 alerts when merging 6f0563e into c3ef4d9 - view on LGTM.com new alerts:
|
This pull request introduces 7 alerts when merging 5061abe into 0fe4180 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 90.77% 87.31% -3.47%
==========================================
Files 89 89
Lines 3772 4027 +255
==========================================
+ Hits 3424 3516 +92
- Misses 348 511 +163
|
Co-authored-by: Vedant Shah <[email protected]>
Co-authored-by: Vedant Shah <[email protected]>
Co-authored-by: Vedant Shah <[email protected]>
Co-authored-by: Vedant Shah <[email protected]>
Co-authored-by: Vedant Shah <[email protected]>
Co-authored-by: Vedant Shah <[email protected]>
No description provided.