Skip to content

making it so you can specify images by their sha256 value #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SethHollandsworth merged 1 commit into from
Feb 14, 2023
Merged

making it so you can specify images by their sha256 value #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/confcom/azext_confcom/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def __init__(
) -> None:
self.containerImage = containerImage
if ":" in containerImage:
self.base, self.tag = containerImage.split(":")
self.base, self.tag = containerImage.split(":", 1)
else:
self.base, self.tag = containerImage, "latest"
self._environmentRules = environmentRules
Expand Down
4 changes: 4 additions & 0 deletions src/confcom/azext_confcom/template_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def get_image_info(progress, message_queue, client, tar_mapping, image):
image_info = None
raw_image = None
image_name = f"{image.base}:{image.tag}"
if len(image.tag.split(":")) > 1:
eprint(
f"The image name: {image.tag} cannot have the digest present to use a tarball as the image source"
)
# only try to grab the info locally if that's absolutely what
# we want to do
if tar_mapping:
Expand Down