Skip to content

Added scans for orphaned catalog configs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earlduque merged 2 commits into from
Oct 7, 2022
Merged

Added scans for orphaned catalog configs #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
570cbe5
Added scans for orphaned catalog configs
niamccash Oct 7, 2022
55e633a
Updated with Catalog Config check desc
niamccash Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ Update sets with more than 1000 configuration updates should be broken down into
### Updates in wrong update set scope
The scope for Customer Update [sys_update_xml] records should match the scope of the Update Set in which the Customer Update resides. Having a mismatch may cause Update Sets to generate preview errors meaning you cannot commit them until the errors are resolved.

### Delete orphaned variables
Variables should be used in Catalog Item or a Variable Set. Variables not in use should be deleted.

### Delete Orphaned Catalog Client Scripts
Catalog Client Script should be used in either a Catalog Item or a Variable Set. Catalog Client Scripts not in use should be deleted.

### Update set description should not be empty
Catalog UI policy should be used in either a Catalog Item or a Variable Set. Catalog UI Policies not in use should be deleted.

## Category: Upgradability

### Incident table should not be extended
Expand Down
2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
rMBlYCmi5aiIbIqy_SEizDYcNQHCiNth2daqdZwAkYB9ev4GhRKFrZMaQKljb82s4-lhvCgTTMHzWwKLVpXvkC2Yd1sNKAK0sq25dklq64buUCyoruywUyU-JUMLuJfNnz8p1mv6C245QHvIi79gTyG6jSW10Dgkzwdpmzuh8IljPPUZavn1suq23wi5kI_LZGoGS77ejaPnvOyUvSeoCqgdzpVnEJS7ktL84rmkkEx0ii4eZD0LyjmXRkEGoQMWx-tmccjg56-cPLcXGP-b9DOd-3P4Mk_TeqWKyjvpFkZs1Z1PW6aq02jvHreEX15XU0ajvHIalYuobHFFXvQvzFXIk0z8rppU_ho8GW1yhk1afxcly96rvHYKTqL93AYI8cyvC4KQe9wlTswLeGk2Xjrn5LhFkNoYMkK9CXmNlG3dN1Zoe8WFYKzEcSbK-j-tbAqSiTeWtz6CEzsfv5har5GKuxq-YCXsfrWSOEPMMKHVgNipa4t1O5Cw8vDSCNWr0fIz1J2DngAQh8joTc6NMt3npBFFLwDUpc2VoUHWr11TrJCySDPZQ35CtAF0WO3iH9SZVKnCNXELI_EWuzaRGydH6hKPVQpIsnN042R206uTB9NrltVRMRxR7shrRBe4ydJxv3q0nS_Dz5hnd8aK_T-0HGwjSLvXPjvObTdPZVw
O589J23_6rg8RI4zPqL24ZnzYfjxQdzdt9wcR6E_qoNnoXh5Qp5AAXQEFzU1Y7PlryUFddxtNivvd6Hta75ujW1F-er8XNEHhqwSdOK2Eq6-fb7NldRy03ANC9mi9wSCaHSTPk12iJ2fqoGPrzeS3dscq1kXmZfB3bzn6Fu-nuOf5YacOPTySnt_G4nZTBW89Wlhosb_lciP-7_edKRi_hTWCtQerJlEKlUMiKcPzV8j4ljMuo7ND-nBWpuAmhsXx4F39ZUP9DbhFQau1gw9tUlr-Vd1wxuULhNgpwEW0vvTwRi3J2XeKbnctnFXNrVyuyP8GquwKEhPc45EnbsuApB_bqlt_GroZSuENoI6mddcTrVNJpBXBpbXpLqzmn6MgSpENhyEt6JJgLTnJfnbmEg3W_57TTu2RWHNPSxHqXrO6MP00gA0vwEK-GbblMY0e5Ee1a-iZ0qaqY1PEK87AT1OdEhJHOkTNanl-9zcaRSMJmUsaBiQ680n4C7KZ-mS5I8t1MpfcqyyhMupjtDViswru0c4RccBpXimdDG26Hko4_QL1yTImTmSaat_B1TcxmeiYwCT10KyKI31yJJVa_MsfBfW9VlGAnPUmxr6Z54kxZ8qOYoPs7RawtcboVgIFffy87VIjk4d1BKD-ujpxNllVVkL3fMql7Yw66gDk4Y
39 changes: 39 additions & 0 deletions ...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_1284f489879a855009eaed3e8bbb35d6.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
<scan_table_check action="INSERT_OR_UPDATE">
<active>true</active>
<advanced>false</advanced>
<attributes/>
<category>manageability</category>
<conditions table="item_option_new">cat_itemISEMPTY^variable_setISEMPTY^EQ<item endquery="false" field="cat_item" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
<item endquery="false" field="variable_set" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Variables should be used in Catalog Item or a Variable Set. </description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>Delete orphaned variables</name>
<priority>3</priority>
<resolution_details>If variable is not in use, it should be deleted</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

// Add your code here

})(engine);]]></script>
<short_description>Delete orphaned variables</short_description>
<sys_class_name>scan_table_check</sys_class_name>
<sys_created_by>nia.mccash</sys_created_by>
<sys_created_on>2022-03-15 22:30:47</sys_created_on>
<sys_id>1284f489879a855009eaed3e8bbb35d6</sys_id>
<sys_name>Delete orphaned variables</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_table_check_1284f489879a855009eaed3e8bbb35d6</sys_update_name>
<table>item_option_new</table>
<use_manifest>false</use_manifest>
</scan_table_check>
</record_update>
39 changes: 39 additions & 0 deletions ...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_42653cc9879a855009eaed3e8bbb35f3.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
<scan_table_check action="INSERT_OR_UPDATE">
<active>true</active>
<advanced>false</advanced>
<attributes/>
<category>manageability</category>
<conditions table="catalog_script_client">cat_itemISEMPTY^variable_setISEMPTY^EQ<item endquery="false" field="cat_item" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
<item endquery="false" field="variable_set" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Catalog Client Script should be used in either a Catalog Item or a Variable Set. </description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>Delete Orphaned Catalog Client Scripts</name>
<priority>3</priority>
<resolution_details>If Catalog Client Script is not in use, it should be deleted</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

// Add your code here

})(engine);]]></script>
<short_description>Delete Orphaned Catalog Client Scripts</short_description>
<sys_class_name>scan_table_check</sys_class_name>
<sys_created_by>nia.mccash</sys_created_by>
<sys_created_on>2022-03-15 22:32:14</sys_created_on>
<sys_id>42653cc9879a855009eaed3e8bbb35f3</sys_id>
<sys_name>Delete Orphaned Catalog Client Scripts</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_table_check_42653cc9879a855009eaed3e8bbb35f3</sys_update_name>
<table>catalog_script_client</table>
<use_manifest>false</use_manifest>
</scan_table_check>
</record_update>
39 changes: 39 additions & 0 deletions ...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_4b353cc9879a855009eaed3e8bbb35ed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
<scan_table_check action="INSERT_OR_UPDATE">
<active>true</active>
<advanced>false</advanced>
<attributes/>
<category>manageability</category>
<conditions table="catalog_ui_policy">catalog_itemISEMPTY^variable_setISEMPTY^EQ<item endquery="false" field="catalog_item" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
<item endquery="false" field="variable_set" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Catalog UI policy should be used in either a Catalog Item or a Variable Set. </description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>Delete Orphaned Catalog UI Policies</name>
<priority>3</priority>
<resolution_details>If Catalog UI policy is not in use, it should be deleted</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

// Add your code here

})(engine);]]></script>
<short_description>Delete Orphaned Catalog UI Policies</short_description>
<sys_class_name>scan_table_check</sys_class_name>
<sys_created_by>nia.mccash</sys_created_by>
<sys_created_on>2022-03-15 22:31:33</sys_created_on>
<sys_id>4b353cc9879a855009eaed3e8bbb35ed</sys_id>
<sys_name>Delete Orphaned Catalog UI Policies</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_table_check_4b353cc9879a855009eaed3e8bbb35ed</sys_update_name>
<table>catalog_ui_policy</table>
<use_manifest>false</use_manifest>
</scan_table_check>
</record_update>