Skip to content

fix #4 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tscholak merged 3 commits into from
Oct 18, 2021
Merged

fix #4 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd99a93
fix #4
tscholak Oct 18, 2021
8e00e0c
model_args.gradient_checkpointing -> training_args.gradient_checkpoin…
tscholak Oct 18, 2021
a8b9e49
model_args.gradient_checkpointing -> training_args.gradient_checkpoin…
tscholak Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions seq2seq/run_seq2seq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ def main() -> None:
num_beams=data_training_args.num_beams,
num_beam_groups=data_training_args.num_beam_groups,
diversity_penalty=data_training_args.diversity_penalty,
gradient_checkpointing=model_args.gradient_checkpointing,
use_cache=not model_args.gradient_checkpointing,
gradient_checkpointing=training_args.gradient_checkpointing,
use_cache=not training_args.gradient_checkpointing,
)

# Initialize tokenizer
Expand Down
4 changes: 0 additions & 4 deletions seq2seq/utils/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,3 @@ class ModelArguments:
"with private models)."
},
)
gradient_checkpointing: bool = field(
default=False,
metadata={"help": "Will enable gradient / activation checkpointing"},
)