-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from conda to uv #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollmer
reviewed
Jan 2, 2025
ollmer
reviewed
Jan 21, 2025
ollmer
reviewed
Jan 21, 2025
ollmer
reviewed
Jan 21, 2025
ollmer
reviewed
Jan 21, 2025
ollmer
reviewed
Jan 21, 2025
ollmer
reviewed
Jan 21, 2025
ollmer
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the base image for CI actions and we're good to go.
ollmer
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv manages our dev and 2 optional dependencies.
Simply run:
uv sync --all-extras
(create a .venv and install all requirements from pyproject.toml)uv run -m ...
(like python -m ...)This will make easy to update dependencies:
uv pip list --outdated
(visualize outdated dependencies)uv sync --upgrade
(upgrade all dependencies)uv sync --all-extras --upgrade-package accelerate==1.2.0
(update a specific library to a specific version)uv tree
The pyproject.toml was updated using these commands (and then manually relaxing versioning):
uv add -r requirements.txt
uv add -r requirements.dev.txt --dev
uv add -r requirements.converters.txt --optional converters
uv add -r requirements.finetune.txt --optional finetune
TODO:
uv build