New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct os_type determination while on cygwin #575

Merged

SergeyPirogov merged 1 commit into SergeyPirogov:master from wwakabobik:4.0.1

Jul 28, 2023

Contributor

wwakabobik commented Jul 27, 2023

Add correct os_type determination while on cygwin
Up-to date README.md


          - Add correct os_type determination while on cygwin

cdd928a

- Up-to date README.md

SergeyPirogov merged commit 18268c1 into SergeyPirogov:master

Owner

SergeyPirogov commented Jul 28, 2023

@wwakabobik Thanks

Contributor Author

wwakabobik commented Jul 28, 2023

@wwakabobik Thanks

You're welcome. Tried to make docs actual :)

rain01 commented Aug 2, 2023

https://github.com/SergeyPirogov/webdriver_manager/pull/575/files#diff-ba18bbaec92175d45609614ad55533eedd3f40c3902a34b3e31f6f068cbb7970R42
Shouldn't this be:

elif pl == "win32" or pl == "cygwin":

Owner

SergeyPirogov commented Aug 2, 2023

@rain01 open a pr please

wwakabobik deleted the 4.0.1 branch

August 2, 2023 20:29

wwakabobik restored the 4.0.1 branch

August 2, 2023 20:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet