fix chromedriver download #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdedViner
approved these changes
Aug 6, 2023
|
Thank you for this patch, @jayph88! Downgrading to 3.9.1 and modifying the code with the rows you provided helped. |
|
@jayph88 Please merge the PR |
|
@jayph88 Review and Please merge the PR |
|
I do not have access |
|
@SergeyPirogov Could you please help in merging the PR |
|
@jayant-fegade @jayph88 @SergeyPirogov Able to see one of the test failed after merging the PR for test (3.11, 4.10.0, ubuntu-latest) FAILED tests/test_edge_driver.py::test_edge_manager_with_selenium - selenium.common.exceptions.WebDriverException: Message: unknown error: unrecognized Microsoft Edge version: Chrome/116.0.5845.140 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #566