Kernel/USB+Net: Add a USB CDC-ECM Network Adapter Driver

.github/actions/cache-restore/action.yml

@@ -95,6 +95,15 @@ runs:
           echo "toolchain_version=$(echo ${version} | cut -d'.' -f1)" >> $GITHUB_OUTPUT
         fi
 
+    - name: 'Show cache storage'
+      shell: bash
+      env:
+        GH_TOKEN: ${{ github.token }}
+      run: |
+        echo "::group::gh cache list"
+        gh cache list --limit 100
+        echo "::endgroup::"
+
     - name: 'Toolchain Prebuilt Cache'
       uses: actions/cache/restore@v4
       id: 'toolchain-prebuilt'
@@ -154,22 +163,16 @@ runs:
       uses: actions/cache@v4
       with:
         path: ${{ inputs.download_cache_path }}/TZDB
-        key: TimeZoneData-${{ hashFiles('Meta/CMake/time_zone_data.cmake') }}-${{ steps.date-stamp.outputs.timestamp }}
-        restore-keys: |
-          TimeZoneData-${{ hashFiles('Meta/CMake/time_zone_data.cmake') }}
+        key: TimeZoneData-${{ hashFiles('Meta/CMake/time_zone_data.cmake') }}
 
     - name: 'UnicodeData cache'
       uses: actions/cache@v4
       with:
           path: ${{ inputs.download_cache_path }}/UCD
-          key: UnicodeData-${{ hashFiles('Meta/CMake/unicode_data.cmake') }}-${{ steps.date-stamp.outputs.timestamp }}
-          restore-keys: |
-            UnicodeData-${{ hashFiles('Meta/CMake/unicode_data.cmake') }}
+          key: UnicodeData-${{ hashFiles('Meta/CMake/unicode_data.cmake') }}
 
     - name: 'UnicodeLocale cache'
       uses: actions/cache@v4
       with:
           path: ${{ inputs.download_cache_path }}/CLDR
-          key: UnicodeLocale-${{ hashFiles('Meta/CMake/locale_data.cmake') }}-${{ steps.date-stamp.outputs.timestamp }}
-          restore-keys: |
-              UnicodeLocale-${{ hashFiles('Meta/CMake/locale_data.cmake') }}
+          key: UnicodeLocale-${{ hashFiles('Meta/CMake/locale_data.cmake') }}

.github/actions/cache-save/action.yml

@@ -51,6 +51,16 @@ inputs:
 runs:
   using: "composite"
   steps:
+    - name: 'Show cache storage'
+      shell: bash
+      env:
+        GH_TOKEN:
+          ${{ github.token }}
+      run: |
+        echo "::group::gh cache list"
+        gh cache list --limit 100
+        echo "::endgroup::"
+
     - name: 'Toolchain Prebuilt Cache'
       uses: actions/cache/save@v4
       # Do not waste time and storage space by updating the toolchain cache from a PR,
@@ -82,7 +92,7 @@ runs:
 
     - name: 'Serenity Compiler Cache'
       uses: actions/cache/save@v4
-      if: ${{ inputs.serenity_ccache_path != '' }}
+      if: ${{ github.event_name != 'pull_request' && inputs.serenity_ccache_path != '' }}
       with:
         path: ${{ inputs.serenity_ccache_path }}
         key: ${{ inputs.serenity_ccache_primary_key }}
@@ -95,3 +105,12 @@ runs:
 
         echo "Serenity Compiler Cache"
         CCACHE_DIR=${{ inputs.serenity_ccache_path }} ccache -s
+
+    - name: 'Show cache storage'
+      shell: bash
+      env:
+        GH_TOKEN: ${{ github.token }}
+      run: |
+        echo "::group::gh cache list"
+        gh cache list --limit 100
+        echo "::endgroup::"

.github/actions/setup/action.yml

@@ -69,7 +69,7 @@ runs:
 
         sudo apt-get update
         sudo apt-get remove clang-{14..18} clang++-{14..18} libclang-{14..18}-dev llvm-{14..18}
-        sudo apt-get install clang-format-20 ccache e2fsprogs libmpfr-dev libmpc-dev optipng qemu-utils qemu-system-i386 generate-ninja libegl1-mesa-dev
+        sudo apt-get install clang-format-20 ccache e2fsprogs libmpfr-dev libmpc-dev optipng qemu-utils qemu-system-i386 qemu-system-arm qemu-system-riscv64 generate-ninja libegl1-mesa-dev
         sudo apt-get install clang-20 clang++-20 llvm-20 llvm-20-dev
 
     - name: Enable KVM group perms

.github/workflows/dev-container.yml

@@ -22,7 +22,7 @@ jobs:
     steps:
 
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6.0.1
 
       - name: Login to GitHub Container Registry
         uses: docker/login-action@v3

.github/workflows/label-pull-requests.yml

@@ -13,9 +13,9 @@ jobs:
   label_pull_request:
     runs-on: ubuntu-24.04
     if: always() && github.repository == 'SerenityOS/serenity'
-    
+
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
 
       - name: Label pull request
         uses: actions/github-script@v8

.github/workflows/lagom-template.yml

@@ -31,10 +31,10 @@ jobs:
       # Pull requests can trail behind `master` and can cause breakage if merging before running the CI checks on an updated branch.
       # Luckily, GitHub creates and maintains a merge branch that is updated whenever the target or source branch is modified. By
       # checking this branch out, we gain a stabler `master` at the cost of reproducibility.
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
         if: ${{ github.event_name != 'pull_request' }}
 
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
         if: ${{ github.event_name == 'pull_request' }}
         with:
           ref: refs/pull/${{ github.event.pull_request.number }}/merge

.github/workflows/manpages.yml

@@ -9,16 +9,21 @@ on:
 jobs:
   convert_using_pandoc:
     runs-on: ubuntu-24.04
-    if: always() && github.repository == 'SerenityOS/serenity' && github.ref == 'refs/heads/master'
+    if: github.repository == 'SerenityOS/serenity' && github.ref == 'refs/heads/master'
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
+        with:
+          persist-credentials: false
+
       - uses: r-lib/actions/setup-pandoc@v2
         with:
           pandoc-version: '2.13'
+
       - name: Actually build website
         run: ./Meta/build-manpages-website.sh
+
       - name: Deploy to GitHub pages
-        uses: JamesIves/github-pages-deploy-action@v4.7.4
+        uses: JamesIves/github-pages-deploy-action@v4.7.6
         with:
           git-config-name: BuggieBot
           git-config-email: buggiebot@serenityos.org

.github/workflows/pull-requests-label-workflows.yml

@@ -0,0 +1,15 @@
+name: Label Workflows
+
+on:
+  pull_request:
+    types: [ labeled, opened, synchronize, reopened ]
+
+jobs:
+  Coverage:
+    if: github.repository == 'SerenityOS/serenity' && contains(github.event.pull_request.labels.*.name, '📑 pr-run-coverage-build')
+    uses: ./.github/workflows/serenity-template.yml
+    with:
+      toolchain: 'Clang'
+      os: ubuntu-24.04
+      arch: 'x86_64'
+      coverage: 'ON'

.github/workflows/serenity-template.yml

@@ -36,10 +36,10 @@ jobs:
       # Pull requests can trail behind `master` and can cause breakage if merging before running the CI checks on an updated branch.
       # Luckily, GitHub creates and maintains a merge branch that is updated whenever the target or source branch is modified. By
       # checking this branch out, we gain a stabler `master` at the cost of reproducibility.
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
         if: ${{ github.event_name != 'pull_request' }}
 
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
         if: ${{ github.event_name == 'pull_request' }}
         with:
           ref: refs/pull/${{ github.event.pull_request.number }}/merge
@@ -50,6 +50,11 @@ jobs:
           os: 'Serenity'
           arch: ${{ inputs.arch }}
 
+      - name: Set Disk Size for Coverage Builds
+        if: ${{ inputs.coverage == 'ON' }}
+        # Using 5GiB here is arbitrary.
+        run: echo "SERENITY_DISK_SIZE_BYTES=5368709120" >> $GITHUB_ENV
+
       # === PREPARE FOR BUILDING ===
 
       - name: Lint
@@ -135,6 +140,7 @@ jobs:
           CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
 
       - name: Save Caches
+        if: ${{ inputs.coverage == 'OFF' }}
         uses: ./.github/actions/cache-save
         with:
           arch: ${{ inputs.arch }}
@@ -157,7 +163,7 @@ jobs:
         run: ninja install && ninja qemu-image
 
       - name: Run On-Target Tests
-        if: ${{ inputs.debug_options == 'NORMAL_DEBUG' && inputs.arch != 'aarch64' && inputs.arch != 'riscv64' }}
+        if: ${{ inputs.debug_options == 'NORMAL_DEBUG' }}
         working-directory: ${{ steps.build-parameters.outputs.build_directory }}
         env:
           SERENITY_QEMU_CPU: "max,vmx=off"
@@ -200,11 +206,10 @@ jobs:
           SERENITY_ARCH: ${{ inputs.arch }}
 
       # FIXME: Deploy the static html pages somewhere
-      # FIXME: Alter script to also (instead?) produce a raw coverage.txt file for ingestion into sonar cloud
       # Note: tmp_profile_data/Coverage.profdata has the entire combined profile data, but creating the raw txt requires
       #       all of the instrumented binaries and the profdata file.
       - name: Upload Coverage Results
-        if: ${{ inputs.coverage == 'ON' }}
+        if: ${{ inputs.coverage == 'ON' && github.event_name != 'pull_request' }}
         uses: actions/upload-artifact@v5
         with:
           name: serenity-coverage

.github/workflows/social-media.yml

@@ -3,32 +3,12 @@ name: Social media notifications
 on: [ push ]
 
 jobs:
-  notify_twitter:
-    runs-on: ubuntu-24.04
-    if: always() && github.repository == 'SerenityOS/serenity' && github.ref == 'refs/heads/master'
-
-    steps:
-      - uses: actions/checkout@v5
-      - uses: actions/setup-node@v6
-        with:
-          node-version: '14'
-      - run: npm i twit
-      - run: |
-          node ${{ github.workspace }}/Meta/tweet-commits.js << 'EOF'
-          ${{ toJSON(github.event) }}
-          EOF
-        env:
-          CONSUMER_KEY: ${{ secrets.CONSUMER_KEY }}
-          CONSUMER_SECRET: ${{ secrets.CONSUMER_SECRET }}
-          ACCESS_TOKEN: ${{ secrets.ACCESS_TOKEN }}
-          ACCESS_TOKEN_SECRET: ${{ secrets.ACCESS_TOKEN_SECRET }}
-
   notify_mastodon:
     runs-on: ubuntu-24.04
     if: always() && github.repository == 'SerenityOS/serenity' && github.ref == 'refs/heads/master'
 
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6.0.1
       - uses: actions/setup-node@v6
         with:
           node-version: '14'

.github/workflows/wasm.yml

@@ -13,16 +13,19 @@ jobs:
     if: github.repository == 'SerenityOS/serenity'
     strategy:
       fail-fast: false
+
     steps:
       - name: Checkout SerenityOS/serenity
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6.0.1
+        with:
+          persist-credentials: false
 
       - name: Checkout SerenityOS/libjs-data libjs-wasm
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6.0.1
         with:
-          repository: SerenityOS/libjs-data
           path: libjs-data
           ref: libjs-wasm
+          repository: SerenityOS/libjs-data
 
       - name: "Set up environment"
         uses: ./.github/actions/setup
@@ -97,7 +100,7 @@ jobs:
           tar --exclude='.[^/]*' -czvf libjs-wasm.tar.gz -C ${{ github.workspace }}/libjs-data .
 
       - name: Deploy to GitHub
-        uses: JamesIves/github-pages-deploy-action@v4.7.4
+        uses: JamesIves/github-pages-deploy-action@v4.7.6
         if: github.ref == 'refs/heads/master'
         with:
           git-config-name: BuggieBot
@@ -108,7 +111,6 @@ jobs:
           folder: ${{ github.workspace }}/libjs-data
 
       - name: Upload artifact package
-        if: github.ref == 'refs/heads/master'
         uses: actions/upload-artifact@v5
         with:
           name: serenity-js-wasm

AK/ByteString.h

@@ -6,6 +6,10 @@
 
 #pragma once
 
+#ifdef KERNEL
+#    error This file should not be included in the kernel. Use KString instead.
+#endif
+
 #include <AK/Format.h>
 #include <AK/Forward.h>
 #include <AK/RefPtr.h>

AK/CMakeLists.txt

@@ -15,6 +15,7 @@ set(AK_SOURCES
     FuzzyMatch.cpp
     GenericLexer.cpp
     Hex.cpp
+    InternetChecksum.cpp
     JsonObject.cpp
     JsonParser.cpp
     JsonPath.cpp

AK/Enumerate.h

@@ -11,8 +11,9 @@
 namespace AK {
 
 namespace Detail {
+
 template<typename Iterable>
-class Enumerator {
+struct Enumerator {
     using IteratorType = decltype(declval<Iterable>().begin());
     using ValueType = decltype(*declval<IteratorType>());
 
@@ -21,35 +22,28 @@ class Enumerator {
         ValueType value;
     };
 
-public:
-    Enumerator(Iterable&& iterable)
-        : m_iterable(forward<Iterable>(iterable))
-        , m_iterator(m_iterable.begin())
-        , m_end(m_iterable.end())
-    {
-    }
-
-    Enumerator const& begin() const { return *this; }
-    Enumerator const& end() const { return *this; }
+    struct Iterator {
+        Enumeration operator*() { return { index, *iterator }; }
+        Enumeration operator*() const { return { index, *iterator }; }
 
-    Enumeration operator*() { return { m_index, *m_iterator }; }
-    Enumeration operator*() const { return { m_index, *m_iterator }; }
+        bool operator!=(Iterator const& other) const { return iterator != other.iterator; }
 
-    bool operator!=(Enumerator const&) const { return m_iterator != m_end; }
+        void operator++()
+        {
+            ++index;
+            ++iterator;
+        }
 
-    void operator++()
-    {
-        ++m_index;
-        ++m_iterator;
-    }
+        size_t index { 0 };
+        IteratorType iterator;
+    };
 
-private:
-    Iterable m_iterable;
+    Iterator begin() { return { 0, iterable.begin() }; }
+    Iterator end() { return { 0, iterable.end() }; }
 
-    size_t m_index { 0 };
-    IteratorType m_iterator;
-    IteratorType const m_end;
+    Iterable iterable;
 };
+
 }
 
 template<typename T>