Tests/LibPDF: Add test for embedded jbig2 cross-chunk ref#26203
Merged
nico merged 2 commits intoSerenityOS:masterfrom Sep 10, 2025
Merged
Tests/LibPDF: Add test for embedded jbig2 cross-chunk ref#26203nico merged 2 commits intoSerenityOS:masterfrom
nico merged 2 commits intoSerenityOS:masterfrom
Conversation
github-actions
bot
added
the
👀 pr-needs-review
Renames jbig2-globals.pdf to jbig2-globals-indirect-reference.pdf. No behavior change.
Test case created by copying Tests/LibGfx/test-inputs/jbig2/bitmap-symbol.jbig2, changing the byte at offset 0x31 from 0x01 to 0x00 to make the symbol dictionary segment a global segment instead of associated with page 1, then ran Meta/jbig2_to_pdf.py on that modified file to create the new PDF. The new file contains a JBIG2Globals stream with the symbol dictionary segment, which the main jbig2 data stream refers to. This would've caught the regression fixed in SerenityOS#26199.
nico
force-pushed
the
jbig2-pdf-test
branch
from
6e5688a to
5298cf3
Compare
github-actions
bot
removed
the
👀 pr-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case created by copying
Tests/LibGfx/test-inputs/jbig2/bitmap-symbol.jbig2, changing the byte at
offset 0x31 from 0x01 to 0x00 to make the symbol dictionary segment a
global segment instead of associated with page 1, then ran
Meta/jbig2_to_pdf.py on that modified file to create the new PDF.
The new file contains a JBIG2Globals stream with the symbol dictionary
segment, which the main jbig2 data stream refers to.
This would've caught the regression fixed in #26199.