LibGfx/JBIG2: Check that referred-to segment numbers are small enough#26162
Merged
nico merged 2 commits intoSerenityOS:masterfrom Aug 28, 2025
Merged
LibGfx/JBIG2: Check that referred-to segment numbers are small enough#26162nico merged 2 commits intoSerenityOS:masterfrom
nico merged 2 commits intoSerenityOS:masterfrom
Conversation
They have to be smaller than the current segment's segment number. No real behavior change, just a bit stricter.
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
nico
added a commit
to nico/serenity
that referenced
this pull request
Sep 6, 2025
nico
added a commit
that referenced
this pull request
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They have to be smaller than the current segment's segment number.
No real behavior change, just a bit stricter.
Also log a tiny bit more in JBIG2_DEBUG mode.