-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibJS: Add %TypedArray%.prototype.toSorted #14400
Conversation
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
37f4556
to
9986ce4
Compare
983a5bc
to
4f51fd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, couple of nitpicks :)
The third function should be named something like LibJS: Add tests cases for %TypedArray%.prototype.toSorted
, just toSorted
is ambiguous.
76cece9
to
7a53b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing I missed earlier: %TypedArray%
instead of TypedArray
for the second commit, like in the PR title :)
7a53b20
to
50799dc
Compare
This change implements typed array prototype toSorted function. It also introduces two new TypedArray functions
50799dc
to
5792f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nicely done 🎉
To implement toSorted, this change introduces 2 new TypedArray functions (typed_array_create_same_type, compare_typed_array_elements)