Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJS: Add %TypedArray%.prototype.toSorted #14400

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

beesaferoot
Copy link
Contributor

@beesaferoot beesaferoot commented Jun 27, 2022

To implement toSorted, this change introduces 2 new TypedArray functions (typed_array_create_same_type, compare_typed_array_elements)

@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@beesaferoot beesaferoot force-pushed the typed-array-update branch 6 times, most recently from 37f4556 to 9986ce4 Compare June 27, 2022 00:42
@beesaferoot beesaferoot force-pushed the typed-array-update branch 2 times, most recently from 983a5bc to 4f51fd4 Compare June 27, 2022 20:55
Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, couple of nitpicks :)

The third function should be named something like LibJS: Add tests cases for %TypedArray%.prototype.toSorted, just toSorted is ambiguous.

Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing I missed earlier: %TypedArray% instead of TypedArray for the second commit, like in the PR title :)

This change implements typed array prototype toSorted function.

It also introduces two new TypedArray functions
Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nicely done 🎉

@linusg linusg merged commit 104330d into SerenityOS:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants