Add background commands with polling #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoosuaKoskinen
force-pushed
the
seravo-plugin-2/polling
branch
from
85b5b7f to
90a2f67
Compare
Moppa5
reviewed
Jul 2, 2021
Moppa5
approved these changes
Jul 2, 2021
JoosuaKoskinen
force-pushed
the
seravo-plugin-2/polling
branch
from
90a2f67 to
abcdd93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes in this PR?
Adds possibility to run commands on background and polling to see when it has finished.
Also added a test-page which is enabled in Seravo Plugin debug mode and there's an example usage of polling.
Why are we doing this? Any context or related work?
Needed for long operations and related to #465.
Where should a reviewer start?
You can try the example on test-page.