Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade 2021/aug #1386

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Dependency upgrade 2021/aug #1386

merged 3 commits into from
Sep 1, 2021

Conversation

blaskodaniel
Copy link
Contributor

date-io is skipped as usual (material-ui date picker only work with the currently installed version)

react and react-dom cannot be updated to 17.x yet, we are waiting for https://github.com/enzymejs/enzyme/issues/2429 this issue. related PR: https://github.com/enzymejs/enzyme/pull/2430

Storybook:
webpack and ts-loader is not upgradable on sn-react-component-docs (storybook). No stable release currently support webpack 5.

cannot update to typescript 4.3.x cause this: storybookjs/storybook#15067
we should wait for a new storybook version

cannot update to storybook (6.2.8) at all not compatible with the new ts
styleguidist/react-docgen-typescript#356

react-responsive --> throws error in tests

babel-plugin-add-import-extension --> cannot update cause it add .js extension to .css imports

cypress: we should wait for a stable version. cypress 8
cypress-io/cypress#17574

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
All committers have signed the CLA.

@sensenet
Copy link

sensenet bot commented Sep 1, 2021

Site name Url Last deploy
sn-app-dev https://612f512b3958e1b201100cc9--sn-app-dev.netlify.app Wed Sep 01 2021 - 10:08:46 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://612f511c156d669cad13b085--sn-react-component-docs-dev.netlify.app Wed Sep 01 2021 - 10:08:30 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1386 (38d39e6) into develop (0b289e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1386   +/-   ##
========================================
  Coverage    92.28%   92.28%           
========================================
  Files          246      246           
  Lines         6841     6841           
  Branches      1817     1817           
========================================
  Hits          6313     6313           
  Misses         528      528           
Impacted Files Coverage Δ
...ges/sn-editor-react/src/components/bubble-menu.tsx 57.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b289e5...38d39e6. Read the comment docs.

@blaskodaniel blaskodaniel merged commit bbd4c6a into develop Sep 1, 2021
@blaskodaniel blaskodaniel deleted the feature/depupgrade202108 branch September 1, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants