glm5 fix precision key name #976
Merged
Claude / Claude Code Review
completed
Mar 29, 2026 in 13m 57s
Code review found 2 important issues
Found 4 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 2 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | .github/configs/nvidia-master.yaml:1815 |
Missing benchmark script glm5_fp4_b200.sh after precision rename |
| 🔴 Important | .github/configs/nvidia-master.yaml:1812-1816 |
Missing perf-changelog.yaml update (BLOCKING per repo policy) |
| 🟡 Nit | .github/configs/nvidia-master.yaml:1812-1818 |
Config key name inconsistent with precision value after fix |
Annotations
Check failure on line 1815 in .github/configs/nvidia-master.yaml
claude / Claude Code Review
Missing benchmark script glm5_fp4_b200.sh after precision rename
The precision rename from `nvfp4` to `fp4` breaks B200 benchmark execution because the corresponding shell script was not renamed. Both `runners/launch_b200-nb.sh` and `runners/launch_b200-dgxc.sh` dynamically construct the benchmark script path using the `PRECISION` env var, so they will now look for `benchmarks/single_node/glm5_fp4_b200.sh`, which does not exist — only `glm5_nvfp4_b200.sh` is present. All GLM-5 NVFP4 B200 benchmark jobs will fail at runtime with "No such file or directory"; th
Check failure on line 1816 in .github/configs/nvidia-master.yaml
claude / Claude Code Review
Missing perf-changelog.yaml update (BLOCKING per repo policy)
This PR modifies `.github/configs/nvidia-master.yaml` (changing `precision: nvfp4` → `precision: fp4` for `glm5-nvfp4-b200-sglang`) but does not update `perf-changelog.yaml`. Per the repo's own policy in `.github/workflows/claude-pr-review.yml` lines 122–126, this is a 🔴 **BLOCKING** issue. A changelog entry documenting the precision key rename must be added to `perf-changelog.yaml` with a reference to PR #976 before this PR can merge.
Check warning on line 1818 in .github/configs/nvidia-master.yaml
claude / Claude Code Review
Config key name inconsistent with precision value after fix
The config key `glm5-nvfp4-b200-sglang` still embeds `nvfp4` while `precision: fp4` after this fix, breaking the established `{model-prefix}-{precision}-{hardware}-{framework}` naming pattern. Consider renaming the key to `glm5-fp4-b200-sglang` and updating the corresponding reference in `perf-changelog.yaml`.
Loading