Skip to content

[AMD] Fix slurm command for AMD devices #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cquil11 merged 8 commits into from
Mar 23, 2026
Merged

[AMD] Fix slurm command for AMD devices #929

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
13dd1d4
slurm command fix
seungrokj Mar 23, 2026
e4f812f
update perf changelog
cquil11 Mar 23, 2026
2657489
add --exclusive to mi355x multinode
cquil11 Mar 23, 2026
4a0d50d
Merge branch 'main' into srok/srun_mi355x_fix
cquil11 Mar 23, 2026
c8eae19
fix: scope PR to MI355X only, remove MI325X changes
cquil11 Mar 23, 2026
60b418c
chore: clarify perf-changelog description for MI355X --exclusive
cquil11 Mar 23, 2026
7650e06
Update perf-changelog.yaml
cquil11 Mar 23, 2026
bca1293
Merge branch 'main' into srok/srun_mi355x_fix
cquil11 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions benchmarks/multi_node/amd_utils/submit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ fi
sbatch_cmd=(
sbatch
--parsable
--exclusive
-N "$NUM_NODES"
-n "$NUM_NODES"
"${NODELIST_OPT[@]}"
Expand Down
8 changes: 8 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,3 +1015,11 @@
- "Config concurrency: 32-256"
- "update image to vllm/vllm-openai-rocm:v0.18.0"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/927

- config-keys:
- "*mi355x*"
- "*mi325x*"
description:
- "Add --exclusive option to salloc commands on MI325X and MI355X nodes which may yield performance improvements"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/929

2 changes: 1 addition & 1 deletion runners/launch_mi325x-amd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ LOCK_FILE="${SQUASH_FILE}.lock"

set -x

JOB_ID=$(salloc --partition=$PARTITION --gres=gpu:$TP --cpus-per-task=256 --time=480 --no-shell --job-name="$RUNNER_NAME" 2>&1 | tee /dev/stderr | grep -oP 'Granted job allocation \K[0-9]+')
JOB_ID=$(salloc --partition=$PARTITION --gres=gpu:$TP --exclusive --cpus-per-task=256 --time=480 --no-shell --job-name="$RUNNER_NAME" 2>&1 | tee /dev/stderr | grep -oP 'Granted job allocation \K[0-9]+')

if [ -z "$JOB_ID" ]; then
echo "ERROR: salloc failed to allocate a job"
Expand Down
2 changes: 1 addition & 1 deletion runners/launch_mi355x-amds.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ else
LOCK_FILE="${SQUASH_FILE}.lock"

set -x
salloc --partition=$PARTITION --gres=gpu:$TP --cpus-per-task=128 --time=180 --no-shell --job-name="$RUNNER_NAME"
salloc --partition=$PARTITION --gres=gpu:$TP --exclusive --cpus-per-task=128 --time=180 --no-shell --job-name="$RUNNER_NAME"
JOB_ID=$(squeue --name="$RUNNER_NAME" -h -o %A | head -n1)

Comment thread
cquil11 marked this conversation as resolved.
srun --jobid=$JOB_ID bash -c "docker stop \$(docker ps -a -q)"
Expand Down
Loading