-
Notifications
You must be signed in to change notification settings - Fork 163
[AMD] Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8) #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+94
−1
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3c65a3
Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8)
github-actions[bot] 8a05f40
Update perf-changelog.yaml
functionstackx 612bd72
Update perf-changelog.yaml
functionstackx 0ba11ba
Increase MI325X slurm time limit from 3hrs to 8hrs
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| source "$(dirname "$0")/../benchmark_lib.sh" | ||
|
|
||
| check_env_vars \ | ||
| MODEL \ | ||
| TP \ | ||
| CONC \ | ||
| ISL \ | ||
| OSL \ | ||
| MAX_MODEL_LEN \ | ||
| RANDOM_RANGE_RATIO \ | ||
| RESULT_FILENAME | ||
|
|
||
| if [[ -n "$SLURM_JOB_ID" ]]; then | ||
| echo "JOB $SLURM_JOB_ID running on $SLURMD_NODENAME" | ||
| fi | ||
|
|
||
| hf download "$MODEL" | ||
|
|
||
| # Set HIP_VISIBLE_DEVICES to match ROCR_VISIBLE_DEVICES for Ray compatibility in vLLM 0.14+ | ||
| if [ -n "$ROCR_VISIBLE_DEVICES" ]; then | ||
| export HIP_VISIBLE_DEVICES="$ROCR_VISIBLE_DEVICES" | ||
| fi | ||
|
|
||
| SERVER_LOG=/workspace/server.log | ||
| PORT=${PORT:-8888} | ||
|
|
||
| # following AMD andy luo's recipe | ||
| # https://x.com/linluo77/status/2017024513595301985 | ||
| set -x | ||
| vllm serve $MODEL --port $PORT \ | ||
| --tensor-parallel-size=$TP \ | ||
| --gpu-memory-utilization 0.95 \ | ||
| --max-model-len $MAX_MODEL_LEN \ | ||
| --block-size=64 \ | ||
| --disable-log-requests \ | ||
| --trust-remote-code \ | ||
| --mm-encoder-tp-mode data > $SERVER_LOG 2>&1 & | ||
|
|
||
| SERVER_PID=$! | ||
|
|
||
| # Wait for server to be ready | ||
| wait_for_server_ready --port "$PORT" --server-log "$SERVER_LOG" --server-pid "$SERVER_PID" | ||
|
|
||
| run_benchmark_serving \ | ||
| --model "$MODEL" \ | ||
| --port "$PORT" \ | ||
| --backend vllm \ | ||
| --input-len "$ISL" \ | ||
| --output-len "$OSL" \ | ||
| --random-range-ratio "$RANDOM_RANGE_RATIO" \ | ||
| --num-prompts "$((CONC * 10))" \ | ||
| --max-concurrency "$CONC" \ | ||
| --result-filename "$RESULT_FILENAME" \ | ||
| --result-dir /workspace/ \ | ||
| --trust-remote-code | ||
|
|
||
| # After throughput, run evaluation only if RUN_EVAL is true | ||
| if [ "${RUN_EVAL}" = "true" ]; then | ||
| run_eval --framework lm-eval --port "$PORT" --concurrent-requests $CONC | ||
| append_lm_eval_summary | ||
| fi | ||
| set +x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The
pr-linkon line 6 points to PR #857, which was reverted by PR #900. Since this PR #901 is the one that actually lands the Kimi K2.5 INT4 MI325X benchmark, the link should be updated tohttps://github.com/SemiAnalysisAI/InferenceX/pull/901so the changelog traces back to the correct, non-reverted PR.Extended reasoning...
What the bug is
The
perf-changelog.yamlentry forkimik2.5-int4-mi325x-vllmhas itspr-linkfield set tohttps://github.com/SemiAnalysisAI/InferenceX/pull/857. However, PR #857 was reverted by PR #900 (commitaaec16f). This PR #901 re-introduces the exact same changes, as stated in the PR description: "Re-opens the changes from #857 (which was reverted in #900)".How it manifests
Anyone reviewing the performance changelog and clicking the PR link for the Kimi K2.5 INT4 MI325X benchmark will be taken to PR #857, which is a reverted/closed PR. This is confusing because:
#734forkimik2.5-int4-mi355x-vllm,#825forkimik2.5-fp4-mi355x-vllm).Step-by-step proof
f7135acmerged PR [AMD] Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8) #857 adding the Kimi K2.5 INT4 MI325X benchmark.aaec16fthen reverted [AMD] Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8) #857 via PR [AMD] Revert "Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8)" #900 with message:Revert "Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8) (#857)" (#900) [skip-sweep].perf-changelog.yamlstill referencespull/857.https://github.com/SemiAnalysisAI/InferenceX/pull/857leads to a reverted PR, not the one that actually lands the config.Impact
This is a minor documentation/traceability issue. It does not affect benchmark correctness or CI functionality. However, it breaks the convention that
pr-linkpoints to the PR that merges the change, which is important for changelog auditing and attribution.Fix
Change line 6 of
perf-changelog.yamlfrom:to: