Skip to content

[AMD] Add new FP8 FP4 sweep points for MI355X Disagg#823

Merged
chunfangamd merged 21 commits into
mainfrom
amd/mi355x-dsfp4-feb25
Mar 3, 2026
Merged

[AMD] Add new FP8 FP4 sweep points for MI355X Disagg#823
chunfangamd merged 21 commits into
mainfrom
amd/mi355x-dsfp4-feb25

Conversation

@billishyahao

@billishyahao billishyahao commented Feb 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This patch is to improve MI355X disagg through

  • Add more sweep configs for MI355X FP8/FP4 Disagg
  • Add TP/DP/EP size < 8 support
  • Support DSR1-0528 MTP Disagg
  • Bump SGL mori image to Feb 27

@billishyahao billishyahao requested a review from a team February 28, 2026 14:55
@functionstackx

functionstackx commented Feb 28, 2026

Copy link
Copy Markdown
Collaborator

thanks @billishyahao

any idea on when these commits will be upstreamed?

sgl-project/sglang@main...Duyi-Wang:sglang:amd_mori_0227

@billishyahao

billishyahao commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator Author

thanks @billishyahao

any idea on when these commits will be upstreamed?

sgl-project/sglang@main...Duyi-Wang:sglang:amd_mori_0227

@functionstackx Hi, this change should be on sglang main branch now sgl-project/sglang#19416

@billishyahao

billishyahao commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Only 2 out of 30 cases failed in https://github.com/SemiAnalysisAI/InferenceX/actions/runs/22560887225/attempts/1?pr=823

@billishyahao

billishyahao commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator Author

All failures are passed with latest sweep: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/22585101508

@billishyahao

billishyahao commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator Author

Latest sweep is on-going https://github.com/SemiAnalysisAI/InferenceX/actions/runs/22606513106

chunfangamd
chunfangamd approved these changes Mar 3, 2026
View reviewed changes

@chunfangamd chunfangamd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunfangamd chunfangamd enabled auto-merge (squash) March 3, 2026 06:24
@billishyahao

billishyahao commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator Author

@functionstackx @cquil11 Could you review this PR? Thanks!
All configs are passed.
https://github.com/SemiAnalysisAI/InferenceX/actions/runs/22606513106

@chunfangamd chunfangamd merged commit 4706e70 into main Mar 3, 2026
22 of 36 checks passed
@chunfangamd chunfangamd deleted the amd/mi355x-dsfp4-feb25 branch March 3, 2026 17:03
@claude claude Bot mentioned this pull request Apr 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cquil11 cquil11 cquil11 approved these changes

@chunfangamd chunfangamd chunfangamd approved these changes

Assignees

No one assigned

Labels

AMD sweep-enabled

Projects

InferenceMAX Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@billishyahao @functionstackx @cquil11 @chunfangamd