Skip to content

[AMD] Update search-space for ATOM DSR1 configs - #699

Merged
cquil11 merged 8 commits into
SemiAnalysisAI:mainfrom
ChuanLi1101:patch-1
Feb 25, 2026
Merged

[AMD] Update search-space for ATOM DSR1 configs#699
cquil11 merged 8 commits into
SemiAnalysisAI:mainfrom
ChuanLi1101:patch-1

Conversation

@ChuanLi1101

@ChuanLi1101 ChuanLi1101 commented Feb 13, 2026 •
edited by cquil11
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Consolidate DSR1 FP4 MI355X ATOM & ATOM-MTP search space to TP=8 only (TP=4 commented out)
  • Extend concurrency range to 256 across all sequence lengths (1k1k, 1k8k, 8k1k)
  • Fix MTP 1k8k conc-start from 256 → 4 to enable full concurrency sweep

@ChuanLi1101
ChuanLi1101 requested a review from a team as a code owner February 13, 2026 17:49
ChuanLi1101

This comment was marked as outdated.

Sign in to view

@ChuanLi1101

ChuanLi1101 commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator Author

The original search space was configured with limited settings and didn’t fully cover the Pareto frontier, especially for the newly added MTP cases. We’ve updated the configuration so we can now observe the full curve in the full sweep.

@seungrokj

seungrokj commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

/sweep test-config --config-files .github/configs/amd-master.yaml --runner-config .github/configs/runners.yaml --config-keys dsr1-fp4-mi355x-atom-mtp dsr1-fp4-mi355x-atom

@github-actions

github-actions Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

@seungrokj Kicking off a sweep.

Run: https://github.com/InferenceMAX/InferenceMAX/actions/runs/21997709058
Command: test-config --config-files .github/configs/amd-master.yaml --runner-config .github/configs/runners.yaml --config-keys dsr1-fp4-mi355x-atom-mtp dsr1-fp4-mi355x-atom
Pinned ref: 4c44854
Approval: not required (trusted collaborator).

@functionstackx

functionstackx commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

@pr-claude review plz

functionstackx
functionstackx reviewed Feb 16, 2026
View reviewed changes
Comment thread .github/configs/amd-master.yaml Outdated
@ChuanLi1101 @functionstackx
Update search-space configurations in amd-master.yaml
21b7546 
revise the search space config
@ChuanLi1101 @functionstackx
Update conc-end values in amd-master.yaml
958a967 
Updated to fullscan
@ChuanLi1101 @functionstackx
Update amd-master.yaml
861c918 
Reduce the search space to depends less on the compute as most of the pareto frontier fall under TP=8.
@functionstackx

functionstackx commented Feb 20, 2026

Copy link
Copy Markdown
Collaborator

@claude add perf changelog.yaml to dsr1-fp4-mi355x-atom & dsr1-fp4-mi355x-atom-mtp and add an description of change and then review the PR plz. lgtm to me but want ur second eye claude please

@Klaud-Cold

Klaud-Cold commented Feb 20, 2026

Copy link
Copy Markdown
Collaborator

Claude Code is working…

I'll analyze this and get back to you.

View job run

@cquil11

cquil11 commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

@claude add perf changelog.yaml to dsr1-fp4-mi355x-atom & dsr1-fp4-mi355x-atom-mtp and add an description of change and then review the PR plz. lgtm to me but want ur second eye claude please

@Klaud-Cold

Klaud-Cold commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

Claude Code is working…

I'll analyze this and get back to you.

View job run

@cquil11

cquil11 commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

@seungrokj @ChuanLi1101 Was it your intention to comment out TP 4 scenarios??

@cquil11 cquil11 changed the title Update search-space configurations in amd-master.yaml [AMD] Update search-space for ATOM DSR1 configs Feb 23, 2026
seungrokj
seungrokj reviewed Feb 24, 2026
View reviewed changes
Comment thread .github/configs/amd-master.yaml Outdated
seungrokj
seungrokj reviewed Feb 24, 2026
View reviewed changes
Comment thread .github/configs/amd-master.yaml Outdated
seungrokj
seungrokj reviewed Feb 24, 2026
View reviewed changes
Comment thread .github/configs/amd-master.yaml Outdated
@seungrokj

seungrokj commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

@seungrokj @ChuanLi1101 Was it your intention to comment out TP 4 scenarios??
I left a comment inline. I think we should keep tp4 for certain concurrencies.

@ChuanLi1101 @cquil11

@ChuanLi1101
Update amd-master.yaml
9f35390 
Revise the changes to make sure we get the pareto's frontier.
@ChuanLi1101
Update amd-master.yaml
a18adc3 
update the search space
ChuanLi1101
ChuanLi1101 commented Feb 25, 2026
View reviewed changes

@ChuanLi1101 ChuanLi1101 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the search space to keep only the pareto's frontier points.

cquil11
cquil11 approved these changes Feb 25, 2026
View reviewed changes

@cquil11 cquil11 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cquil11
cquil11 merged commit dee9cf7 into SemiAnalysisAI:main Feb 25, 2026
cquil11 added a commit that referenced this pull request Feb 25, 2026
@cquil11
Revert "[AMD] Update search-space for ATOM DSR1 configs (#699)"
bb18fc8 
This reverts commit dee9cf7.
@cquil11 cquil11 mentioned this pull request Feb 25, 2026
Merged
cquil11 added a commit that referenced this pull request Feb 25, 2026
@cquil11
Revert "[AMD] Update search-space for ATOM DSR1 configs (#699)" (#791)
96e54ca 
This reverts commit dee9cf7.
cquil11 added a commit that referenced this pull request Feb 25, 2026
@cquil11
Revert "Revert "[AMD] Update search-space for ATOM DSR1 configs (#699)…
9c8646e 
…" (#791)"

This reverts commit 96e54ca.
@cquil11 cquil11 mentioned this pull request Feb 25, 2026
Merged
cquil11 added a commit that referenced this pull request Feb 25, 2026
@cquil11
[AMD] Re-apply: Update search-space for ATOM DSR1 configs (#792)
8944a35 
* Revert "Revert "[AMD] Update search-space for ATOM DSR1 configs (#699)" (#791)"

This reverts commit 96e54ca.

* Update amd-master.yaml
@claude claude Bot mentioned this pull request Mar 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@functionstackx functionstackx functionstackx left review comments
@seungrokj seungrokj seungrokj left review comments
@cquil11 cquil11 cquil11 approved these changes

Assignees

No one assigned

Labels

AMD sweep-enabled

Projects

InferenceMAX Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChuanLi1101 @seungrokj @functionstackx @Klaud-Cold @cquil11