Repository navigation
[NVIDIA][AgentX] Qwen3.8-Flash-Next B300 SGLang / [NVIDIA][AgentX] Qwen3.8-Flash-Next B300 SGLang - #4683
Conversation
…en3.8-Flash-Next B300 SGLang Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Thanks for the contribution!
中文感谢你的贡献!
|
…en3.8-Flash-Next B300 SGLang Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=41117066222 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=41117066222 |
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. The recipe rewrite involves many engine-tuning choices on a nightly image, and the changed paths have NVIDIA CODEOWNERS, so a human review is still worthwhile.
What was reviewed:
- The recipe's YAML anchor/merge-key overrides. The GPU-only rows (tp4_c1, c2, c12, c24) null out the base HiCache and Mamba settings and set KV_OFFLOADING=none / TOTAL_CPU_DRAM_GB=0. The c48 and c80 rows keep the base HiCache with fp8 KV.
- Whether the master-config search-space rows (TP4/EP4 at c1, TP1 at c2/12/24, TP1 with HiCache at c48/80) match the override names. Also whether the recipe leaves image, model, precision and benchmark type/command to the binder.
- The new perf-changelog entry. It is appended at the tail and covers the one changed config key. Its pr-link is still the pull/XXX placeholder.
Extended reasoning...
The change rewrites one single-node srt-slurm AgentX recipe for Qwen3.8-Flash-Next NVFP4 on B300. It also updates the matching nvidia-master.yaml entry (image, model and a three-row search space) and appends one perf-changelog entry. It touches no security-sensitive code, only benchmark configuration. I didn't approve because nvidia-master.yaml and the b300-* recipe directory are covered by NVIDIA CODEOWNERS entries. Also, the recipe adds dozens of new server args and feature-flag env vars whose performance trade-offs need a domain owner to judge.
This review covers commit f06a819, which is no longer the latest commit on this pull request; later commits are not covered by it.
|
/use 41117066222 |
|
@hshrivastava-droid staged run 41117066222. This run remains available across future |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: hshrivastava-droid <hshrivastava@nvidia.com>
|
[by Claude Code] The SGLang cookbook integration of this PR's AgentX config ( The commands mirror the launch measured in run 41117066222, pinned by this PR's |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have: Checklist items
Additional detail section:
中文验证任务及所选评测在 Signed: |
❌❌❌ REJECTED ❌❌❌@RohitNagraj Blocking: the recipe enables the conditional sparse verify-sampling branch ( ❌ Check 2 (Evals pass): FAIL — No eval covers the enabled sparse verify-sampling path: Passed and not applicable checks✅ Check 0 (CODEOWNER): PASS — RohitNagraj is a named owner of ✅ Check 1 (In-PR sweep + evals): PASS — In-PR commit ✅ Check 3 (Upstream recipe): PASS — sglang#47560 is MERGED (2026-10-31). Its ✅ Check 4 (Reuse command): PASS — ✅ Check 5 (Latest template): PASS — All 20 items in the current PR_REVIEW_CHECKLIST.md template are present and checked. ✅ Check 6 (Upstream images): PASS — ✅ Check 7 (Deprecated models): PASS — MODELS.md lists ✅ Check 8 (No arch hacks): PASS — No ✅ Check 9 (Spec-decode chat template): PASS — The AgentX replay client drives ✅ Check 10 (No engine patches): PASS — No setup script, patch, overlay or wheel install. Every ✅ Check 11 (Agentic golden AL): PASS — The connector injected ➖ Check 12 (Append-only): N/A — The new changelog entry is not ✅ Check 13 (Draft precision): PASS — The embedded MTP head of ✅ Check 14 (Pareto coverage): PASS — Qwen3.8-Flash-Next / agentic-coding / b300_sglang / fp4 / p90 E2EL: 6 of 8 measured points are on the frontier ( ✅ Check 15 (PR description): PASS — The body's search space, low-concurrency tuning claims, digest-pinned image and validation (8 throughput points, 2 evals at ✅ Check 16 (NVIDIA overview): PASS — Qwen3.8-Flash-Next has an SGLang checkmark in the Framework Recipes table of the NVIDIA overview. ➖ Check 17 (Metrics publication): N/A — This is an SGLang aggregated config, not Dynamo TRT-LLM. ✅ Check 18 (Recipe/image/sweep consistency): PASS — There are no generation errors. Master TP4/EP4, TP1 and HiCache rows map to the Assessed commit: |
|
[by Claude Code] sgl-project/sglang#47929 has been merged. This PR's AgentX config ( The commands mirror the launch measured in run 41117066222, pinned by this PR's |
functionstackx
left a comment
There was a problem hiding this comment.
Approved at Oren’s request, conditional on your confirmation that this optimization is used in production. The greedy-only eval coverage gap described in the discussion is accepted on that basis; this approval does not establish non-greedy correctness or independently verify production use.
Resolve the perf-changelog.yaml conflict by keeping main's entries and re-appending this PR's unchanged entry at the end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Ingest report — ✅ Results ingested into the Ingest workflow · Merge Ingest run · Benchmark source run
benchmarkFiles 9, rawBenchmarkRows 16, coveredByPerJobFiles 8, purgedPoints 0, failedRunRows 0, runStatsNew 0, runStatsDuplicate 0, evalSamplesNew 2638, gpuMetricSamplesNew 87243, powerPublicationPoints 8, changelogEntriesWritten 1 Counts cover only this run. Rows: benchmark_results, eval_results, agentic rows linked to a trace, gpu_metrics series. This comment updates if the ingest is rerun. 中文Ingest 报告 — ✅ 结果已写入 上表仅统计本次运行写入的数据,各行单位依次为 benchmark_results 行、eval_results 行、已关联 trace 的 agentic 行和 gpu_metrics 序列。重新运行 ingest 时本评论会原地更新。 |
Summary
Update
qwen3.8next-fp4-b300-sglang-agentic-mtpto the NVIDIA Qwen3.8-Flash-Next NVFP4 checkpoint on digest-pinned SGLangnightly-dev-cu13-20261028-586355a8.The AgentX matrix covers TP4/EP4 at concurrency 1 and 2, TP1/EP1 GPU-only at concurrency 1, 2, 12 and 24, and TP1/EP1 with HiCache at concurrency 48 and 80. TP1 c1 shares the existing c2 tuning; TP4 c2 follows TP4 c1 with a four-request admission cap. The higher-concurrency variants are unchanged by this addition.
Image:
lmsysorg/sglang:nightly-dev-cu13-20261028-586355a8@sha256:b4f09a2ccbcfcc262d49600c3cd7f8581a793ea7d104947257b6a95500953b90Validation
Full sweep 41117066222 passed at
d06564bc533cc54584ef6a35837336a2b4b84421: all eight AgentX throughput points, both selected evaluation jobs, and result collection succeeded. Concurrency 1 and 2 passed at both TP1 and TP4. A performance delta against published main results has not been verified.Run evidence
Performance preview and accuracy preview.
AI model disclosure
claude-sonnet-5-5): prepared the original PR.中文
将
qwen3.8next-fp4-b300-sglang-agentic-mtp更新为 NVIDIA Qwen3.8-Flash-Next NVFP4 检查点,并使用固定 digest 的 SGLangnightly-dev-cu13-20261028-586355a8镜像。AgentX 测试矩阵覆盖 TP4/EP4 并发 1、2,TP1/EP1 GPU-only 并发 1、2、12、24,以及启用 HiCache 的 TP1/EP1 并发 48、80。TP1 c1 复用现有 c2 调优设置;TP4 c2 沿用 TP4 c1 设置,并将请求准入上限设为 4。本次补充未修改更高并发配方。
Claude Sonnet 5.5 (
claude-sonnet-5-5) 准备了原始 PR;GPT-6 Astra 补充了低并发覆盖、更新了描述并监控 CI。完整 sweep 41117066222 已在
d06564bc533cc54584ef6a35837336a2b4b84421通过:八个 AgentX 吞吐测试点、两个选定评测任务及结果收集均成功。TP1 和 TP4 的并发 1、2 均已通过。尚未验证相对 main 已发布结果的性能变化。