Repository navigation
[AMD][MI35X] Qwen3.8-Flash-Next FP4 SGLang agentic MTP: 20261031 image, monokernel at c1-c8 / [AMD][MI35X] Qwen3.8-Flash-Next:20261031 镜像,c1-c8 启用 monokernel #4542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chunfangamd
merged 27 commits into
main
from
chang/qwen3.8-flash-fp4-mi355x-sglang-agentic-baseline-r02
Nov 3, 2026
+44
−14
Merged
Changes from 20 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
00b99af
Qwen3.8-Flash-Next MI355X AgentX baseline: merged upstream PRs and th…
ChangLiu0709 2e018fe
Qwen3.8-Flash-Next MI355X AgentX baseline: mem-fraction-static 0.9 at…
ChangLiu0709 33c460f
Qwen3.8-Flash-Next MI355X AgentX baseline round 02: hc_mix, GEMM tabl…
ChangLiu0709 400295d
Qwen3.8-Flash-Next MI355X baseline round 02: aiter #5992, #6670 and #…
ChangLiu0709 a1dbc93
Qwen3.8-Flash-Next MI355X baseline round 02: pr-link #4542
ChangLiu0709 6b3ddb6
Qwen3.8-Flash-Next MI355X baseline round 02: lmsysorg/sglang-rocm:v0.…
ChangLiu0709 69234e2
qwen3.8next: import CapabilityRequirement in monokernel patch for SGL…
ChangLiu0709 ecb3b0f
qwen3.8next: regenerate the SGLang patches, move the monokernel to sg…
ChangLiu0709 093c13b
qwen3.8next: move to the 20261030 image, patch only merged PRs
ChangLiu0709 c4d912a
Merge remote-tracking branch 'origin/main' into chang/qwen3.8-flash-f…
ChangLiu0709 66c33fd
qwen3.8next: recipe comments match the patch set
ChangLiu0709 a5c969f
qwen3.8next: drop the AITER patches, run the image's AITER as shipped
ChangLiu0709 f9a8f9e
qwen3.8next: rename the setup script to qwen3.8next-sgl-amd-mono-29.sh
ChangLiu0709 964932c
qwen3.8next: run c8, c12 and c16 on the default path, drop the monoke…
ChangLiu0709 83e5d30
Revert "qwen3.8next: run c8, c12 and c16 on the default path, drop th…
ChangLiu0709 dc0ba10
qwen3.8next: patch in sglang#47485, enable the AITER lm_head GEMM
ChangLiu0709 83a477f
qwen3.8next: credit the round 02 co-authors
ChangLiu0709 297196b
qwen3.8next: drop the sglang#47485 lm_head patch from the round 02 ba…
ChangLiu0709 7ba9d07
qwen3.8next: disable integer all-reduce on the round 02 baseline
ChangLiu0709 bb8bd50
qwen3.8next: move round 02 onto the 20261031 image and drop the setup…
ChangLiu0709 90fc8ff
Merge origin/main into the round 02 baseline
ChangLiu0709 bdf93a7
Merge branch 'main' into chang/qwen3.8-flash-fp4-mi355x-sglang-agenti…
ChangLiu0709 54b9aad
Merge origin/main into the round 02 baseline
ChangLiu0709 006cf66
Merge origin/main into the round 02 baseline
chunfangamd e7a7306
fix(qwen3.8next): evaluate the MI355X monokernel points and serve thi…
chunfangamd 64527ed
Merge branch 'main' into chang/qwen3.8-flash-fp4-mi355x-sglang-agenti…
ChangLiu0709 ed02f66
Merge branch 'main' into chang/qwen3.8-flash-fp4-mi355x-sglang-agenti…
chunfangamd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 After merge, no default sweep runs an accuracy eval on the new monokernel used for c1-c8. Only c16, on the default path, gets GSM8K. Eval groups are keyed on engine env, not CLI args. The c1-c8 overrides switch kernels only through args (
enable-amd-monokernel, nulled ReplaySSM/PLE offload), and all six points share one env. Fix: give the monokernel points (c1-c8) their own engine env, using the image's env switch if it has one, so they get their own GSM8K job, or require anall-evalsrun before/use. Same pattern at 4 sites (agentic.yaml:82, :98, :114, :130).Why this was flagged
mark_eval_entries (infx/matrix/generate.py:802-815) groups single-node agentic rows by model, runner, framework, precision, spec-decoding, dp-attn, image and
_engine_env(entry). It picks only the highest-conc row in each group for GSM8K. engine_environment (infx/matrix/fingerprint.py:81-102) serializes only the recipeenvironmentand each role'senv. EVALS.md:21-26 says a point that switches to a mono or megakernel through an env var gets its own eval, but CLI args do not split groups. override_c1/c2/c4/c8 differ from c12/c16 only in args (lines 80-84, 96-100, 112-116, 128-132). All six points have the same role env, base env plus SGLANG_AITER_HONOR_EXPLICIT_MEM_FRACTION='1'. So with the default label, the single group runs GSM8K only at c16, which uses ReplaySSM and the default verify path. On the base branch, all six points ran that same path, so the c16 eval covered every point. After this change, the FlyDSL verify/draft kernel at c1-c8 has no accuracy check. The PR description's own validation cites only "the c16 eval" plus throughput runs.Verification:
engine_environmentin infx/matrix/fingerprint.py:81-102 serializes only recipeenvironmentand each role'senv. In agentic.yaml, c1/c2/c4/c8 (lines 76-138) switch to the monokernel only through args. So they form one group, and only c16 gets GSM8K. On the base commit, c1-c8 ran the same kernel path as c16, so the c16 eval covered them.