Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ base:
identity:
model: {}
frameworks:
dynamo: "1.6.0.dev20261019"
sglang: "0.0.0.dev1+gc1c287a42"
dynamo: "1.6.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) Published disagg results will carry a stale router label, dynamo-router 1.6.0.dev20261019, while the recipe now says the image ships dynamo 1.6.0. The recipe identity moves dynamo to "1.6.0". The master key's router at configs/nvidia-master.yaml:9548 still says "1.6.0.dev20261019". Fix: set that router version to "1.6.0" so both match the pinned image, and mention the Dynamo change in the new perf-changelog entry. Before this PR the two values matched.

Why this was flagged

The key dsv41flash-fp4-gb300-dynamo-sglang-agentic-dspark-disagg uses dynamo: install: false (disagg-variants.yaml:11-12), so Dynamo comes from the image. This PR changes the recipe identity to dynamo: "1.6.0" for the new 20261025 image. The master entry keeps router: { name: dynamo-router, version: "1.6.0.dev20261019" } (nvidia-master.yaml:9548). CONFIGS.md:145 says router versions "label what the image ships". generate.py:53 exports the point's router as ROUTER_METADATA, and results/agentic/init.py:214 writes it into each result's router field. So after merge, every c1228/c2884/c4096 result is tagged with the old Dynamo dev build. On the base branch both values were 1.6.0.dev20261019, the version the 10853 changelog entry says the c1c287a4 image ships. No check catches this. workload.py _bind_components only checks the router version when a repo setup script installs it, and this recipe installs nothing. The new changelog entry (perf-changelog.yaml:11217) also leaves out the Dynamo version change.

Verification: Trigger: any sweep of dsv41flash-fp4-gb300-dynamo-sglang-agentic-dspark-disagg on the new image. disagg-variants.yaml changes the identity to dynamo: "1.6.0", but configs/nvidia-master.yaml:9548 still has router version "1.6.0.dev20261019". On the base both said 1.6.0.dev20261019. No validator compares the router version with the recipe identity.

sglang: "0.0.0.dev1+g656331295"
dynamo:
install: false
request_plane: tcp
Expand Down
2 changes: 1 addition & 1 deletion inferencex-e2e/configs/nvidia-master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9657,7 +9657,7 @@ dsv41flash-fp4-gb300-dynamo-sglang-agentic-agg:
dp-attn: false

dsv41flash-fp4-gb300-dynamo-sglang-agentic-dspark-disagg:
image: lmsysorg/sglang:nightly-dev-cu13-20261021-c1c287a4@sha256:b0473834763b2753e069cb96c1acaf235ba7fd632ccd9bbeb44da809c437fdeb
image: lmsysorg/sglang:nightly-dev-cu13-20261025-65633129@sha256:069efa1d6a2d58309529f53eeee34c39d69b1cdb455eaf7fb8de83e3fd0be727
model: deepseek-ai/DeepSeek-V4.1-Flash
model-prefix: dsv41flash
runner: cluster:gb300-nv
Expand Down
7 changes: 7 additions & 0 deletions inferencex-e2e/perf-changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11325,3 +11325,10 @@
description:
- "Update SGLang image from v0.5.21-cu130 to v0.5.22-cu130."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/4512

- config-keys:
- dsv41flash-fp4-gb300-dynamo-sglang-agentic-dspark-disagg
description:
- "Update the SGLang image from nightly-dev-cu13-20261021-c1c287a4 to nightly-dev-cu13-20261025-65633129."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/4515
scenario-type: [agentic-coding]
Loading