Repository navigation
[Klaud Cold] [TileRT] GLM-5.3 FP8 MI355X AgentX: tilert 0.1.6.post3 + vLLM 0.28/ATOM prefill / [Klaud Cold] [TileRT] GLM-5.3 FP8 MI355X AgentX:tilert 0.1.6.post3 + vLLM 0.28/ATOM prefill #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
07e763d
tilert: GLM-5.3 FP8 MI355X AgentX on 0.1.6.post3 with a vLLM 0.28 + A…
CrimsonDump b33ff66
perf-changelog: point the tilert post3 entry at #3617
CrimsonDump a42bb46
Merge remote-tracking branch 'origin/main' into klaud/glm5.3-fp8-mi35…
functionstackx 98394e6
perf-changelog: point the tilert post3 entry at #3623
functionstackx 0775ae6
fix(glm5.3-tilert): re-enable Mooncake HIP dmabuf on the prefill rank
Oseltamivir 5935c46
Merge branch 'main' into klaud/glm5.3-fp8-mi355x-tilert-post3
Oseltamivir 4c34fb5
fix(glm5.3-tilert): pin the prefill KV cache to 100 GiB
Oseltamivir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The newly appended changelog entry's pr-link still points at the fork PR #3617, not at this PR, contradicting the PR's own description ("the changelog pr-link now points at this PR") and leaving the merged record misattributed. validate_added_pr_link() in infx/workflows/validate_perf_changelog.py requires an appended entry's pr-link to equal
pull/{pr_number}of the PR actually being merged, or be an allowed placeholder;pull/3617is neither once this PR's real number differs. canonicalize_appended_links() then raises ChangelogValidationError instead of rewriting it, since it only rewrites placeholders, not stale literal links. Fix: before merge, set the new entry's pr-link (line 9179) to this PR's own canonical pull/ URL or to an allowed placeholder, not the source fork PR's link.Why this was flagged
The appended perf-changelog.yaml entry at lines 9171-9179 carries
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/3617, the fork PR by @ CrimsonDump being ported, not the number of the PR this diff belongs to (the PR text itself says it is a port of #3617 into a new, different PR). validate_added_pr_link (infx/workflows/validate_perf_changelog.py:139-150) requireslink == expected(built from the real pr_number) or a value in PR_LINK_PLACEHOLDERS;pull/3617matches neither. canonicalize_appended_links (infx/workflows/prepare_perf_changelog_merge.py:79-114) only auto-corrects placeholders, so it raises ChangelogValidationError for a stale literal link, blocking the automated merge-prep/reuse path and contradicting the PR's own claim that the link was already fixed.Verification: The appended changelog block (inferencex-e2e/perf-changelog.yaml:9172-9179) ends at line 9179 with
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/3617— the fork PR being ported, not this PR, contradicting the PR description. validate_added_pr_link (infx/workflows/validate_perf_changelog.py:139-150) requires the link equalpull/{pr_number}or be a placeholder;pull/3617is neither, so it raises ChangelogValidationError.