-
Notifications
You must be signed in to change notification settings - Fork 292
[AMD][AgentX] Tune MI300X Qwen3.5 MORI disaggregation with srt-slurm #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cquil11
wants to merge
4
commits into
main
Choose a base branch
from
agent/mi300x-qwen35-agentx-mori-srt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
252968b
feat(mi300x): focus AgentX MORI tuning on DEP8 and pure TP8
cquil11 6da8c6f
chore(mi300x): skip evals for the requested performance sweep
cquil11 eae1874
chore: merge main and preserve MI300X performance changelog entries
cquil11 7267a73
Add homogeneous MI300X TEP8 points to official AgentX sweep
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
benchmarks/multi_node/srt-slurm-recipes/cluster-configs/mi300x-amd.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # MI300X AMD fleet: shared NFS source/results, node-local images and HF cache. | ||
| # Slurm selects available nodes from compute; drained nodes remain excluded. | ||
| cluster: mi300x-amd | ||
| default_partition: compute | ||
| default_time_limit: "04:00:00" | ||
| gpus_per_node: 8 | ||
| accelerator_vendor: amd | ||
| network_interface: ens50f1np1 | ||
| gpu_sbatch_directive: gres | ||
| use_segment_sbatch_directive: false | ||
| use_exclusive_sbatch_directive: true | ||
| runtime_config_transport: shared-filesystem | ||
| record_launch_plan: true | ||
| default_sbatch_directives: | ||
| # Full-node allocation: all 128 logical CPUs and all RAM on this fleet. | ||
| cpus-per-task: "128" | ||
| mem: "0" | ||
| default_bash_preamble: "ulimit -l unlimited; ulimit -c 0" | ||
| default_mounts: | ||
| /dev/kfd: /dev/kfd | ||
| /dev/dri: /dev/dri | ||
| /dev/infiniband: /dev/infiniband | ||
| /raid/inferencex/models: /hf-cache | ||
| nginx_raise_ulimit: false |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drain requires worker URLs unconditionally
Medium Severity
wait_for_agentic_servers_idlenow treats an emptyAIPERF_SERVER_METRICS_URLSas a fatalSystemExitfor every backend. Existing Dynamo AgentX recipes that rely on this script never set that variable and previously drained from the frontend gauge alone. BecauseSystemExitbypasses the retry handler, any multi-concurrency job exits as soon as drain runs.Reviewed by Cursor Bugbot for commit eae1874. Configure here.