-
Notifications
You must be signed in to change notification settings - Fork 294
Add B200 DeepSeek V4.1 Flash AgentX / 新增 B200 配方 #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4603dee
config: isolate B200 DeepSeek V4.1 Flash AgentX sweep
Oseltamivir 20c29e2
docs: link B200 sweep PR
Oseltamivir 409c430
config: align DeepSeek V4.1 Flash with official TP recipe
Oseltamivir 674aed9
config: use golden synthetic AL for DSv4.1 Flash
Oseltamivir bf437d7
chore: sync main and resolve changelog conflict
Oseltamivir 052a811
chore: merge main into B200 DSv4.1 Flash AgentX
Oseltamivir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| dsv41flash_fp4_vllm_mtp.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import json | ||
| import subprocess | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parents[1] | ||
|
|
||
|
|
||
| def run_bash(command: str, *args: Path | str) -> subprocess.CompletedProcess[str]: | ||
| return subprocess.run( | ||
| ["bash", "-c", command, "bash", *(str(arg) for arg in args)], | ||
| check=False, | ||
| capture_output=True, | ||
| text=True, | ||
| ) | ||
|
|
||
|
|
||
| def test_b200_v41_uses_hf_cache_without_mounting_model_id(tmp_path: Path) -> None: | ||
| log = tmp_path / "launch.jsonl" | ||
| result = run_bash( | ||
| ''' | ||
| mkdir() { :; } | ||
| salloc() { :; } | ||
| squeue() { echo 123; } | ||
| srun() { | ||
| python3 -c 'import json,os,sys; open(sys.argv[1], "a").write(json.dumps({"args":sys.argv[2:], "model":os.environ["MODEL"], "cache":os.environ["HF_HUB_CACHE"]})+"\\n")' "$SRUN_LOG" "$@" | ||
| } | ||
| export MODEL_PREFIX=dsv41flash PRECISION=fp4 FRAMEWORK=vllm | ||
| export MODEL=deepseek-ai/DeepSeek-V4.1-Flash IS_MULTINODE=false | ||
| export SPEC_DECODING=mtp TP=4 RUNNER_NAME=b200-test IS_AGENTIC=1 | ||
| export SCENARIO_SUBDIR=agentic/ EXP_NAME=dsv41flash_tp4_conc1 | ||
| export IMAGE=vllm/test:fixture GITHUB_WORKSPACE="$1" SRUN_LOG="$2" | ||
| cd "$GITHUB_WORKSPACE" | ||
| source runners/launch_b200-nscale-compat.sh | ||
| ''', | ||
| REPO_ROOT, log, | ||
| ) | ||
| assert result.returncode == 0, result.stderr | ||
| serve = json.loads(log.read_text().splitlines()[-1]) | ||
| assert serve["model"] == "deepseek-ai/DeepSeek-V4.1-Flash" | ||
| assert serve["cache"] == "/hf-cache" | ||
| mounts = next(arg for arg in serve["args"] if arg.startswith("--container-mounts=")) | ||
| assert f"{REPO_ROOT}:/ix," in mounts | ||
| assert ":/hf-cache," in mounts | ||
| assert "deepseek-ai/" not in mounts | ||
| assert serve["args"][-2] == "bash" | ||
| assert (REPO_ROOT / serve["args"][-1]).is_file() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing engine-ready timeout override
Medium Severity
The new B200
dsv41flashlaunch path never setsVLLM_ENGINE_READY_TIMEOUT_S, so startup stays on the one-hour default fromdsv41flash_fp4_vllm_mtp.sh. The matching GB300 recipe already needed 7200 seconds for this same image, checkpoint, and TP4 capture after that deadline killed cold graph capture.Reviewed by Cursor Bugbot for commit 052a811. Configure here.