-
Notifications
You must be signed in to change notification settings - Fork 295
feat: support no-evals in perf changelog entries #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) The Chinese translation drops the "combined with no-evals" qualifier, so it reads as an absolute ban on using all-evals/evals-only/eval-min-prefill-ep together (or the two PR modifiers together) — which contradicts actual validator behavior (an entry may freely combine evals-only with eval-min-prefill-ep, or all-evals is just mutually exclusive with evals-only at CLI level, absent no-evals). Chinese-only readers get a false validation rule not present in the English page or the code. Fix: retranslate to explicitly tie the prohibition to no-evals, e.g. "与 no-evals 同时使用 all-evals/evals-only/eval-min-prefill-ep,或在 PR 上同时使用 no-evals 与任一 eval PR modifier,都会被拒绝", matching validation.py's validate_append_only_mode and process_changelog.py's no_evals/all_evals/evals_only check.
Extended reasoning...
English (docs/eval-agentx-procedures.md:20-21): "Combining
no-evalswithall-evals,evals-only, oreval-min-prefill-epon the entry, or with either eval PR modifier, is rejected" — the ban is conditioned on no-evals, matching infx/matrix/validation.py's model_validator (raises only when self.no_evals is True) and process_changelog.py's main() (raises only when any entry.no_evals and args.all_evals/evals_only). The zh page (lines 18-20) renders this as "条目中不能同时使用 all-evals、evals-only 或 eval-min-prefill-ep,PR 也不能同时使用两个 eval modifier 中的任意一个" — omitting the no-evals connector entirely, so it states an entry can never combine those three fields, and a PR can never use both eval modifiers, neither of which the code actually enforces outside the no-evals case. A Chinese-reading operator following only this page would believe legal configurations (e.g. evals-only + eval-min-prefill-ep) are forbidden.Verification: nit (docs-only, no runtime break, but introduces false content the base lacks). English docs/eval-agentx-procedures.md:18-20 conditions the rejection on no-evals: "Combining
no-evalswithall-evals,evals-only, oreval-min-prefill-epon the entry, or with either eval PR modifier, is rejected." This mirrors infx/matrix/validation.py validate_append_only_mode, which raises ONLY when…