-
Notifications
You must be signed in to change notification settings - Fork 292
[Klaud Cold] Update qwen3.5-fp4-b200-sglang-agentic-mtp SGLang image to nightly-dev-cu13-20260907-30705c00 #2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
functionstackx
wants to merge
1
commit into
main
Choose a base branch
from
klaud-cold/qwen3.5-fp4-b200-sglang-agentic-mtp-nightly-dev-cu13-20260907-30705c00
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The new changelog entry sets pr-link to the literal string "PRLINK_PLACEHOLDER", which is not the documented placeholder and will persist as garbage if the PR link is never manually fixed post-merge (docs/configuration-procedures.md:254 permits only
TBDpre-merge, to be replaced with the real PR URL immediately after creation). Fix: usepr-link: TBD(or the actual PR URL once known) instead of a non-standard placeholder string, per the documented convention.Extended reasoning...
docs/configuration-procedures.md line 254 states the only permitted placeholder before a PR exists is
pr-link: TBD, replaced with the real URL right after PR creation. This diff instead writespr-link: PRLINK_PLACEHOLDER(perf-changelog.yaml line 6929), a string that does not match any tooling or convention referenced in the docs. Since perf-changelog.yaml is append-only and byte-sensitive (never edited retroactively per AGENTS.md conventions), if this placeholder is not swept and replaced before/at merge, it becomes a permanent malformed record in the historical changelog, breaking any downstream tooling or scripts that parse pr-link fields expecting either a real GitHub URL or theTBDsentinel.Verification: normal. perf-changelog.yaml:6929 sets
pr-link: PRLINK_PLACEHOLDERon the newly appended entry. The repo's changelog gate rejects this value: utils/validate_perf_changelog.py:144-160 (validate_added_pr_link, invoked from compare_entries at line 206) requires an appended entry's link to be either the exacthttps://github.com/SemiAnalysisAI/InferenceX/pull/<pr_number>or a member of… | normal.…